Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 868
    • Issues 868
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 55
    • Merge Requests 55
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !485

Open
Opened 5 days ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/KiltedKoala](feat): Added e2e tests for boost impressions #1634

Closes #1634

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/boost-impressions-1634 origin/feat/boost-impressions-1634

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff feat/boost-impressions-1634

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/boost-impressions-1634 into master
The source branch is 1 commit behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #76027266 passed with warnings for 4e7405b9 on feat/boost-impressions-1634
            Requires 2 more approvals from Devs and Deployers.
            Emiliano Balbuena
            Emiliano Balbuena
            Marcelo Rivera
            Marcelo Rivera
            Olivia Madrid
            Olivia Madrid
            Brian Hatchet
            Brian Hatchet
            Martin Santangelo
            Martin Santangelo
            Ready to be merged automatically. Ask someone with write access to this repository to merge this request

            Closes #1634

            Deletes source branch

            • Discussion 2
            • Commits 2
            • Pipelines 2
            • Changes 1
            • Loading...
            • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 4 days ago

              approved this merge request

            • Brian Hatchet :speech_balloon: @brianhatchet added 5 commits 19 hours ago

              added 5 commits

              • 4853b2e5...6d942fb6 - 4 commits from branch master
              • 4e7405b9 - Merge branch 'master' into feat/boost-impressions-1634

              Compare with previous version

            • Ben Hayward
              Ben Hayward @benhayward.ben · 17 hours ago
              Developer

              ctrl + f in the Chrome pipeline boost/boost-impressions.spec.js

            • Ben Hayward
              Ben Hayward @benhayward.ben · 33 minutes ago
              Developer

              image

            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
            Please register or sign in to reply
            0 Assignees
            None
            Assign to
            None
            Milestone
            None
            Assign milestone
            None
            Time tracking
            No estimate or time spent
            0
            Labels
            None
            Assign labels
            • View project labels
            Lock merge request
            Unlocked
            9
            9 participants
            user avatar
            Emiliano Balbuena
            user avatar
            Marcelo Rivera
            user avatar
            Olivia Madrid
            user avatar
            Brian Hatchet
            user avatar
            Martin Santangelo
            user avatar
            Juan Manuel Solaro
            user avatar
            Guy Thouret
            Reference: minds/front!485