Skip to content

Minds Frontend
Minds Frontend
Open
Opened by Ben Hayward@benhayward.ben
Report abuse

WIP: [Sprint/KiltedKoala](feat) e2e tests for notification and cleanup functions

Closes #1687 and #1640

Request to merge feat/notification-e2e-1640 into master
The source branch is 2 commits behind the target branch
Open in Web IDE
Pipeline #75834268 passed with warnings for 582b5a7b on feat/notification-e2e-1640
            Requires 2 more approvals from Devs and Deployers.
            This is a Work in Progress

            Closes #1640 and #1687

            Deletes source branch

            You can merge this merge request manually using the
            • Ben Hayward @benhayward.ben added 1 commit

              added 1 commit

              • 582b5a7b - notifs dont seem to be working properly on sandbox, need to figure that out

              Compare with previous version

            • Ben Hayward
              Ben Hayward @benhayward.ben ·
              Developer

              Commented out after hook for now as with it in things cannot be debugged (cypress outputs that the test failed in the after hook if it fails anywhere).

              Notifications don't seem to be working for me on the sandbox.

              comment on user 2s post from user 1. User 2 receives no notification.

            • Brian Hatchet
              Brian Hatchet :speech_balloon: @brianhatchet ·
              Developer

              Don't disable tests if they are not working. That's a terrible habit to get into. We'll get the notifications fixed on sandbox when Mark is available tomorrow.

            • Ben Hayward
              Ben Hayward @benhayward.ben ·
              Developer

              Oh I know. This is just a WIP. It's just this hook here: !492 (diffs)

              The reason is that if the test fails, it will always say that the error is in the after hook and not provide the correct failing section (when its actually in the tests). Because I was testing how it ran in the CI, I needed to leave it out so that I could actually get any outputted error.

            Please register or sign in to reply