(bug): Audio continues on boost rotator
Summary
Reported by @ramialbatal
Rami Albatal: Hi Ben, this post appeared in my rotator: https://www.minds.com/newsfeed/984571580299771904
Rami Albatal: I then revealed the content and played the music... nice music. Then I clicked on the "next" button on top of the rotator to see the next post... but the music continued playing. I think we should stop the music from playing in that case right?
Steps to reproduce
- Find music in the rotator (do it locally else you'll burn a users boosts on dev work).
- Move along boost rotator.
- Still hear music
Platform information
Cross-platform
What is the current bug behavior?
Music keeps playing after the boost is gone.
What is the expected correct behavior?
Music should stop when the boost switches.
Relevant logs and/or screenshots
(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's very hard to read otherwise.)
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)
added 2 - Normal P - Boost T - Bug scoped labels
added Bug Hunter label
changed milestone to %sprint: Interesting Iguana
assigned to @benhayward.ben
changed weight to 3
added Status::InProgress scoped label
automatically removed Status::InProgress label
changed weight to 4
- Developer
Rather than make a seperate task, I'm also going to tackle the UX issue of videos not pausing when they are offscreen altogether.
added Status::InProgress scoped label
mentioned in merge request !446 (closed)
- Developer
Will actually split that into a separate task now that I've got into writing it. There are quite distinctly separate requirements for both, though they may share a common interface.
added Status::Review scoped label and automatically removed Status::InProgress label
added Status::Follow Up scoped label and automatically removed Status::Review label
- Developer
Tried over the weekend to work on this, but could not get boosts working locally. Fresh installing on a new machine mid-week so hopefully, that will be resolved.
changed milestone to %sprint: Jolly Jellyfish
added Squad::Green scoped label
automatically removed Status::Follow Up label
added Status::InProgress scoped label
added Status::InProgress scoped label
changed milestone to %sprint: Kilted Koala
automatically removed Status::InProgress label
added Status::InProgress scoped label
- Developer
We're gonna need to plan this one out a bit more thoroughly because the action of pausing is different for every media type (minds, youtube, vimeo, soundcloud etc).
added Status::Review scoped label and automatically removed Status::InProgress label
mentioned in commit d162b115
mentioned in merge request !495