Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 870
    • Issues 870
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 54
    • Merge Requests 54
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !492

Open
Opened 2 days ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

WIP: [Sprint/KiltedKoala](feat) e2e tests for notification and cleanup functions

Closes #1687 and #1640

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/notification-e2e-1640 origin/feat/notification-e2e-1640

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff feat/notification-e2e-1640

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/notification-e2e-1640 into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #75834268 passed with warnings for 582b5a7b on feat/notification-e2e-1640
            Requires 2 more approvals from Devs and Deployers.
            Brian Hatchet
            Brian Hatchet
            Guy Thouret
            Guy Thouret
            Emiliano Balbuena
            Emiliano Balbuena
            Martin Santangelo
            Martin Santangelo
            Marcelo Rivera
            Marcelo Rivera
            This is a Work in Progress

            Closes #1640 and #1687

            Deletes source branch

            You can merge this merge request manually using the
            • Discussion 1
            • Commits 2
            • Pipelines 2
            • Changes 3
            • Loading...
            • Ben Hayward @benhayward.ben added 1 commit 15 hours ago

              added 1 commit

              • 582b5a7b - notifs dont seem to be working properly on sandbox, need to figure that out

              Compare with previous version

            • Ben Hayward
              Ben Hayward @benhayward.ben · 15 hours ago
              Developer

              Commented out after hook for now as with it in things cannot be debugged (cypress outputs that the test failed in the after hook if it fails anywhere).

              Notifications don't seem to be working for me on the sandbox.

              comment on user 2s post from user 1. User 2 receives no notification.

            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
            Please register or sign in to reply
            0 Assignees
            None
            Assign to
            None
            Milestone
            None
            Assign milestone
            None
            Time tracking
            No estimate or time spent
            0
            Labels
            None
            Assign labels
            • View project labels
            Lock merge request
            Unlocked
            9
            9 participants
            user avatar
            Brian Hatchet
            user avatar
            Guy Thouret
            user avatar
            Emiliano Balbuena
            user avatar
            Martin Santangelo
            user avatar
            Marcelo Rivera
            user avatar
            Juan Manuel Solaro
            user avatar
            Olivia Madrid
            Reference: minds/front!492