Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 858
    • Issues 858
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 51
    • Merge Requests 51
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !491

Open
Opened 1 hour ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/KiltedKoala](feat): Added in comment-tree e2e tests #1635

Closes #1635

Took longer than initially anticipated, decided to make sure the voting works while I was in here.

Note indexes for the functions at ln:29 all equal 2 because that is the position we need for the top element on the comment tree, but the framework is there to grab 2nd, 3rd commments in a clean way.

Edited 1 hour ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/comment-tree-e2e-1635 origin/feat/comment-tree-e2e-1635

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff feat/comment-tree-e2e-1635

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/comment-tree-e2e-1635 into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #75623813 passed with warnings for bdd6f9be on feat/comment-tree-e2e-1635
            Merge request approved. Approved by
            Brian Hatchet
            Brian Hatchet
            Marcelo Rivera
            Marcelo Rivera
            Juan Manuel Solaro
            Juan Manuel Solaro
            Mark Harding
            Mark Harding
            Emiliano Balbuena
            Emiliano Balbuena
            Martin Santangelo
            Martin Santangelo
            Ready to be merged automatically. Ask someone with write access to this repository to merge this request

            Closes #1635

            Deletes source branch

            • Discussion 0
            • Commits 2
            • Pipelines 2
            • Changes 1
            • Loading...
            • Ben Hayward @benhayward.ben changed title from Added in comment-tree e2e tests #1635 to {+Sprint/KiltedKoala: +}Added in comment-tree e2e tests #1635 1 hour ago

              changed title from Added in comment-tree e2e tests #1635 to {+Sprint/KiltedKoala: +}Added in comment-tree e2e tests #1635

            • Ben Hayward @benhayward.ben changed the description 1 hour ago

              changed the description

            • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Green scoped labels 1 hour ago

              added MR::Awaiting Review Squad::Green scoped labels

            • Ben Hayward @benhayward.ben added 1 commit 1 hour ago

              added 1 commit

              • bdd6f9be - xit

              Compare with previous version

            • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 hour ago

              approved this merge request

            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
            Please register or sign in to reply
            0 Assignees
            None
            Assign to
            None
            Milestone
            None
            Assign milestone
            None
            Time tracking
            No estimate or time spent
            2
            Labels
            MR::Awaiting Review Squad::Green
            Assign labels
            • View project labels
            Lock merge request
            Unlocked
            9
            9 participants
            user avatar
            Marcelo Rivera
            user avatar
            Juan Manuel Solaro
            user avatar
            Mark Harding
            user avatar
            Emiliano Balbuena
            user avatar
            Martin Santangelo
            user avatar
            Guy Thouret
            user avatar
            Olivia Madrid
            Reference: minds/front!491