Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 864
    • Issues 864
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 46
    • Merge Requests 46
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !472

Open
Opened 5 days ago by Mark Harding@markeharding
  • Report abuse
Report abuse

WIP: Max's Sort selector rework

Replaces !383 (closed)

Edited 5 days ago by Mark Harding

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b sort-selector-rework origin/sort-selector-rework

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff sort-selector-rework

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge sort-selector-rework into master
The source branch is 11 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #74461717 passed with warnings for 2ba5d6fb on sort-selector-rework
            Requires 2 more approvals from Devs and Deployers.
            Guy Thouret
            Guy Thouret
            Martin Santangelo
            Martin Santangelo
            Juan Manuel Solaro
            Juan Manuel Solaro
            Ben Hayward
            Ben Hayward
            Marcelo Rivera
            Marcelo Rivera
            This is a Work in Progress

            Deletes source branch

            You can merge this merge request manually using the
            • Discussion 2
            • Commits 3
            • Pipelines 2
            • Changes 2
            • Loading...
            • Mark Harding @markeharding mentioned in merge request !383 (closed) 5 days ago

              mentioned in merge request !383 (closed)

            • Mark Harding @markeharding changed the description 5 days ago

              changed the description

            • Mark Harding
              Mark Harding @markeharding · 5 days ago
              Owner

              @mnurzia

              Screen_Shot_2019-08-02_at_6.45.22_PM Is it possible to remove the left border when in collapsed mode?

              Screen_Shot_2019-08-02_at_6.45.17_PM The dropdown now looks to be centred. Could we make it left justified again?

              Screen_Shot_2019-08-02_at_6.45.25_PM Full screen on a macbook pro still doesn't display the options. Could you modify the threshold?

            • Max Nurzia
              Max Nurzia @mnurzia · 7 hours ago

              @markeharding I sent you an email discussing the changes, but as far as I know they seem ready to commit.

            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
            Please register or sign in to reply
            0 Assignees
            None
            Assign to
            None
            Milestone
            None
            Assign milestone
            None
            Time tracking
            No estimate or time spent
            0
            Labels
            None
            Assign labels
            • View project labels
            Lock merge request
            Unlocked
            10
            10 participants
            user avatar
            Guy Thouret
            user avatar
            Martin Santangelo
            user avatar
            Juan Manuel Solaro
            user avatar
            Ben Hayward
            user avatar
            Marcelo Rivera
            user avatar
            Brian Hatchet
            user avatar
            Emiliano Balbuena
            Reference: minds/front!472