[Sprint/InterestingIguana](feat): Offchain boost rate limiting #475
Closes #475
May need to distribute off-chain tokens for staging, using the php-cli. php cli.php rewards issue --username=nemofin --amount=10000
DeveloperNeed to do some testing, and run this by somebody. Not 100% sure I've properly filtered down the transactions as the number coming out is not quite what I'd expect (though is close). Could be related to ES running under low disk constraints.
Resolved by Ben Hayward- Resolved by Ben Hayward
added MR::Requires Changes scoped label
added 2 commits
added 1 commit
- 21f43ead - Updated, added in reduce for counting impressions and extra test
unmarked as a Work In Progress
changed the description
resolved all discussions
resolved all discussions
added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label
mentioned in issue #591
mentioned in issue #592
approved this merge request
approved this merge request
- Developer
@eiennohi @brianhatchet did you test with tokens? I was trying to get into this with kubectl to issue some to people. (this may have to wait till monday but if you haven't already got some, send me your usernames on staging)
added Squad::Green scoped label
- Developer
- boosted for 5000
- boosted dif post for 4000
- boosted dif post for 2000 - error
- boosted for 1000 - success (max of 10k now reached)
- boosted for 1000 - error
Resolved by Ben Haywardresolved all threads
approved this merge request
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Ben Hayward
added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label
resolved all threads
added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label
added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label
- Owner
failing tests
- Resolved by Ben Hayward
- Resolved by Ben Hayward
added 1 commit
- e8c67b01 - Updated to switch a function name and update reduce to have init index
resolved all threads
added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label
- Last updated by Ben Hayward
188 $maxDaily = $this->config->get('max_daily_boost_views'); 189 return $acc + $boost->getImpressions() > $maxDaily; //still allow 10k 190 } 191 192 193 /** 194 * Gets the users last offchain boosts, from the most recent boost backwards in time. 195 * 196 * @param string $type the type of the boost 197 * @param integer $limit default to 10. 198 * @return $existingBoosts 199 */ 200 public function getOffchainBoosts($boost, $limit = 10) { 201 $existingBoosts = $this->getList([ 202 'useElastic' => true, 203 'state' => 'review', - Owner
How does this solve the '10k boosts per day' if we are only checking unapproved boosts?
changed this line in version 13 of the diff
- Developer
Replaced with active flag, as simply removing this line would then include completed, revoked and rejected.
- Developer
How is that?
added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label
added 2 commits
added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label
