WIP: [Sprint/JollyJellyfish](feat) Plus tiers engine#578
Depends on engine#578 Closes mobile-native#1093 (closed)
Need to add tests before im happy.
mentioned in merge request engine!279
changed the description
changed the description
Resolved by Ben Hayward- Resolved by Ben Hayward
- Owner
Looking good. Beware of modal -> modal flow though, I think it will replace it and close the previous one down (so not going back).
Also, please don't push up
fit.. we should open a ticket to put something in the CI to warn us. added MR::Requires Changes Squad::Green scoped labels
DeveloperCrap! Sorry about that. Made a ticket for it here minds#694 (closed)
I'll have a think about it. I had a google and found a few hooks we could maybe use / adapt
resolved all threads
added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label
- Developer
Awaiting feedback to continue and make responsive.
- Developer
Somewhat of a discrepancy from my local and this here pipeline. The engine seems to be functioning correctly, because the new config endpoint served value for plus_guid is available on the site at Minds.blockchain.plus_guid. (can the sandbox using web dev tools).
The front-end here, in contrast to my local does not working at all, as the modal doesn't pop-up.
unmarked as a Work In Progress
marked as a Work In Progress
approved this merge request
DeveloperTested and works great.
@ottman found an issue with responsiveness and the button
Just need to make it not WIP. I will create a card for setting up a pre-git check for removing fits and fdescribes
Edited by Brian Hatchetunapproved this merge request
- Developer
Yep, don't worry, was not going to add that in following feedback, as the whole design could have changed.
- Developer
More feedback from @jotto141
Jack doesnt really seem different than the last one still says "Upgrade - 20 tokens / month" on the plus page. Should just say "Purchase" or "Upgrade" Jack and I still see all of the USD options, need to hide those til we have Stripe working with it and not sure if purchasing should be working yet or not, just getting errors when i try
- Developer
Just a reminder, we still need an answer to what we do about the token limit. Do we make an exception for plus, or raise it?
added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label
- Developer
Updated anyway to meet that feedback - not going to put the values in helm yet as we still need to work out how to handle lifetime without going over the max daily token limit.
