[Sprint/KiltedKoala](chore): Adding in fdescribe / fit checks in git hooks #1608
Partially closes #1608
Try commit an fdescribe or fit.
changed the description
added MR::Awaiting Review Squad::Green scoped labels
- Developer
One thing to note, these may not work unless "chmod +x .githooks/pre-commit" is ran. I've omitted that for now else we'll run into compat issues with Windows - Could use something like this if that is the case https://stackoverflow.com/a/8597411/7396007.
- Developer
Just had to made it executable and it works in the happy path case. Aka, if there is no f* in the code, it won't let you add them. However, there's a problem in the script if you try to remove and existing one. It will detect the change and pick it up as a potential add even if it's a -fdescribe line
It also requires NPM to be installed, so we'll need to broadcast to all developers that they need to update their locals so it sticks.
approved this merge request
- Developer
Approved, but this one definitely requires @markeharding 's blessing