Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 863
    • Issues 863
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 41
    • Merge Requests 41
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !475

Open
Opened 47 minutes ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/KiltedKoala](chore): Adding in fdescribe / fit checks in git hooks #1608

Partially closes #1608

Try commit an fdescribe or fit.

Edited 46 minutes ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/fdesc-hook-1608 origin/feat/fdesc-hook-1608

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff feat/fdesc-hook-1608

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/fdesc-hook-1608 into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #74761651 running for 3a132f1f on feat/fdesc-hook-1608
            Requires 2 more approvals from Devs and Deployers.
            Mark Harding
            Mark Harding
            Emiliano Balbuena
            Emiliano Balbuena
            Martin Santangelo
            Martin Santangelo
            Guy Thouret
            Guy Thouret
            Olivia Madrid
            Olivia Madrid
            Ready to be merged automatically. Ask someone with write access to this repository to merge this request

            Closes #1608

            Deletes source branch

            • Discussion 1
            • Commits 2
            • Pipelines 2
            • Changes 3
            • Loading...
            • Ben Hayward @benhayward.ben changed the description 46 minutes ago

              changed the description

            • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Green scoped labels 40 minutes ago

              added MR::Awaiting Review Squad::Green scoped labels

            • Ben Hayward
              Ben Hayward @benhayward.ben · 38 minutes ago
              Developer

              One thing to note, these may not work unless "chmod +x .githooks/pre-commit" is ran. I've omitted that for now else we'll run into compat issues with Windows - Could use something like this if that is the case https://stackoverflow.com/a/8597411/7396007.

            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
            Please register or sign in to reply
            0 Assignees
            None
            Assign to
            None
            Milestone
            None
            Assign milestone
            None
            Time tracking
            No estimate or time spent
            2
            Labels
            MR::Awaiting Review Squad::Green
            Assign labels
            • View project labels
            Lock merge request
            Unlocked
            9
            9 participants
            user avatar
            Mark Harding
            user avatar
            Emiliano Balbuena
            user avatar
            Martin Santangelo
            user avatar
            Guy Thouret
            user avatar
            Olivia Madrid
            user avatar
            Brian Hatchet
            user avatar
            Marcelo Rivera
            Reference: minds/front!475