Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 856
    • Issues 856
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 39
    • Merge Requests 39
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !193

Closed
Opened 4 months ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/Votes](bug): Horizontal scroll mobile newsfeed fix

Couldn't think of any cases where this would cause an issue but if I've missed one, let me know and I can apply it only to narrow screens.

Closes #519 (closed)

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git horizontal-scroll-mobile-newsfeed-fix
git checkout -b benhayward.ben/front-horizontal-scroll-mobile-newsfeed-fix FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-horizontal-scroll-mobile-newsfeed-fix

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:horizontal-scroll-mobile-newsfeed-fix into master
  • Email patches
  • Plain diff
Pipeline #52038946 passed for 7bb54f7b on benhayward.ben:horizontal-scroll-mobile-newsfeed-fix
    Requires approval.

    Closed by Ben Hayward 15 hours ago

    The changes were not merged into master

    Allows commits from members who can merge to the target branch

    Did not close #519 (closed)

    Deletes source branch

    • Discussion 1
    • Commits 1
    • Pipelines 1
    • Changes 1
    • Loading...
    • Mark Harding @markeharding added MR::Awaiting Review scoped label 1 month ago

      added MR::Awaiting Review scoped label

    • Mark Harding @markeharding added Squad::Green scoped label 2 weeks ago

      added Squad::Green scoped label

    • Ben Hayward
      Ben Hayward @benhayward.ben · 15 hours ago
      Developer

      Issue for this has been already been closed and I am pretty sure that this is fixed

      Edited by Ben Hayward 15 hours ago
    • Ben Hayward @benhayward.ben closed 15 hours ago

      closed

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    0 Assignees
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    2
    Labels
    MR::Awaiting Review Squad::Green
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    1
    1 participant
    user avatar
    Ben Hayward
    Reference: minds/front!193