Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Mobile
Minds Mobile
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 128
    • Issues 128
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 13
    • Merge Requests 13
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • Minds
  • Minds MobileMinds Mobile
  • Merge Requests
  • !278

Merged
Opened 1 week ago by Martin Santangelo@msantang783 of 3 tasks completed3/3 tasks
  • Report abuse
Report abuse

[Sprint/JollyJellyfish] (feat) reimplement boost injector for offline first

  • Reimplement boost injector for offline first
  • Inject boosts in the main newsfeed and discovery all
  • Spec test

This new implementation is cleaner than the previous one, to use it we only need to call setInjectBoost(true) into the feed store.

closes #1122 #1135 #1136 (closed)

Edited 4 days ago by Martin Santangelo

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/msantang78/mobile-native.git sprint/JollyJellyfish.feat.reimplement.boost.injector.offline-first
git checkout -b msantang78/mobile-native-sprint/JollyJellyfish.feat.reimplement.boost.injector.offline-first FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/release/3.9.0
git merge --no-ff msantang78/mobile-native-sprint/JollyJellyfish.feat.reimplement.boost.injector.offline-first

Step 4. Push the result of the merge to GitLab

git push origin release/3.9.0

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge msantang78:sprint/JollyJellyfish.feat.reimplement.boost.injector.offline-first into release/3.9.0
  • Email patches
  • Plain diff
Could not retrieve the pipeline status. For troubleshooting steps, read the documentation.
Merge request approved. Approved by
Mark Harding
Mark Harding
Brian Hatchet
Brian Hatchet

Merged by Mark Harding 1 minute ago

The changes were merged into release/3.9.0 with 66a25402

Pipeline #74543991 running for 66a25402 on release/3.9.0
          • Discussion 0
          • Commits 6
          • Pipelines 3
          • Changes 13
          • Loading...
          • Martin Santangelo @msantang78 changed milestone to %sprint: Jolly Jellyfish 1 week ago

            changed milestone to %sprint: Jolly Jellyfish

          • Martin Santangelo @msantang78 added Squad::Green scoped label 1 week ago

            added Squad::Green scoped label

          • Martin Santangelo @msantang78 changed the description 5 days ago

            changed the description

          • Martin Santangelo @msantang78 added 4 commits 4 days ago

            added 4 commits

            • f85cdc5e - (feat) mock boosted content service
            • 3b57427b - (chore) fix failing tests
            • fb5afb2e - (fix) boosted content service logic
            • 872416f1 - (feat) spec test boosted content service

            Compare with previous version

            Toggle commit list
          • Martin Santangelo @msantang78 unmarked as a Work In Progress 4 days ago

            unmarked as a Work In Progress

          • Martin Santangelo @msantang78 marked the task Spec test as completed 4 days ago

            marked the task Spec test as completed

          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 3 days ago

            approved this merge request

          • Martin Santangelo @msantang78 changed target branch from master to release/3.9.0 2 days ago

            changed target branch from master to release/3.9.0

          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 2 days ago

            approved this merge request

          • Martin Santangelo @msantang78 added 1 commit 1 day ago

            added 1 commit

            • 847e3a30 - (chore) remove console log

            Compare with previous version

          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 day ago

            approved this merge request

          • Mark Harding @markeharding approved this merge request 1 minute ago

            approved this merge request

          • Mark Harding @markeharding merged 1 minute ago

            merged

          • Mark Harding @markeharding mentioned in commit 66a25402 1 minute ago

            mentioned in commit 66a25402

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          sprint: Jolly Jellyfish
          Milestone
          sprint: Jolly Jellyfish
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          1
          Labels
          Squad::Green
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          3
          3 participants
          user avatar
          Mark Harding
          user avatar
          Brian Hatchet
          user avatar
          Martin Santangelo
          Reference: minds/mobile-native!278

          Revert this merge request

          This will create a new commit in order to revert the existing changes.

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.

          Cherry-pick this merge request

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.