(wip) Sort selector rework
New sort-selector interface.
Desktop/Tablet: 
Mobile:
Notably this is still missing some kind of distinction between the algorithms and custom types selectors, as well as the settings icon being in an awkward location, both of which I plan to address soon.
Closed by 
The changes were not merged into master
added MR::Awaiting Review scoped label
- Last updated by Max Nurzia
7 7 > :last-child { 8 8 margin-left: auto; 9 9 } 10 10 11 11 .m-dropdown--list--item { 12 12 cursor: pointer; 13 &.m-sort-selector--custom-type-item, - Owner
sounds like this should be moved up a level? I don't think it need to be inside the
.m-dropdown--list--itemblock changed this line in version 2 of the diff
- Last updated by Max Nurzia
8 8 margin-left: auto; 9 9 } 10 10 11 11 .m-dropdown--list--item { 12 12 cursor: pointer; 13 &.m-sort-selector--custom-type-item, 14 &.m-sort-selector--algorithm-item { 15 width: auto; 16 display: block; 17 text-align: center; 18 .m-sort-selector--item-label-icon { 19 margin-right: 0px; 20 margin-inline: 8px; 21 } 22 } - Owner
spacing (make sure you use spaces and not tabs)
Edited by Mark Harding changed this line in version 2 of the diff
- Last updated by Max Nurzia
61 83 62 84 .m-sort-selector--algorithm-dropdown, 63 85 .m-sort-selector--period-dropdown { 64 .m-dropdown--list { 86 .li { - Owner
can you double check this?
changed this line in version 2 of the diff
- Owner
Nice start @mnurzia ! Left some comments for you
added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label
mentioned in merge request !318 (closed)
added 1 commit
- 59827089 - Fix errors in sort-selector edit, tweak styles
I fixed most of the things you pointed out. However, I couldn't find a way to resolve the issue with the parent selectors cleanly. I'm new to SCSS and there is probably an easier and better looking way of doing it, but I couldn't figure out a solution like you described. I figured that I would commit here and continue trying to fix that in the meantime, since the actual output is acceptable.
-
@markeharding What should I do next here?
- Owner
Hey Max. Moved this over to !472 so it will be on our sandbox sites.
Looks good from a code point of view! Let me know when you are free next week for a quick chat.
closed
mentioned in merge request !472