Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 846
    • Issues 846
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 41
    • Merge Requests 41
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !211

Open
Opened 4 months ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/Wire] (fix): reload when toggling experiments

closes #897 (closed) closes #1630

Edited 10 minutes ago by Marcelo Rivera

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/eiennohi/front.git sprint/Wire.fix.reload-when-turning-on-experiments
git checkout -b eiennohi/front-sprint/Wire.fix.reload-when-turning-on-experiments FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff eiennohi/front-sprint/Wire.fix.reload-when-turning-on-experiments

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge eiennohi:sprint/Wire.fix.reload-when-turning-on-experiments into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #74310410 running for 73ff7e5a on eiennohi:sprint/Wire.fix.reload-when-turning-on-experiments
            Requires approval.
            Ready to be merged automatically. Ask someone with write access to this repository to merge this request

            Allows commits from members who can merge to the target branch

            Closes #1630 and #897 (closed)

            Deletes source branch

            • Discussion 7
            • Commits 6
            • Pipelines 4
            • Changes 2
            1/3 threads resolved
            • Loading...
            • Mark Harding
              Mark Harding @markeharding started a thread on an old version of the diff 4 months ago
              Last updated by Marcelo Rivera 4 months ago
              src/app/app.component.ts
              61 61 console.log('[app]:: language change', this.minds.user.language, this.minds.language);
              62 62 window.location.reload(true);
              63 63 }
              64 if(this.minds.user.canary) {
              • Mark Harding
                Mark Harding @markeharding · 4 months ago
                Owner

                can we fix the spacing?

              • Marcelo Rivera @eiennohi changed this line in version 2 of the diff 4 months ago

                changed this line in version 2 of the diff

              • Marcelo Rivera
                Marcelo Rivera @eiennohi · 4 months ago
                Developer

                fixed!

              • Please register or sign in to reply
            • Marcelo Rivera @eiennohi added 1 commit 4 months ago

              added 1 commit

              • ac039a06 - (fix): code cleanup and styling

              Compare with previous version

            • Mark Harding
              Mark Harding @markeharding started a thread on an old version of the diff 3 months ago
              Last updated by Marcelo Rivera 3 months ago
              src/app/app.component.ts
              61 60 console.log('[app]:: language change', this.minds.user.language, this.minds.language);
              62 61 window.location.reload(true);
              63 62 }
              63 if (this.minds.user.canary) {
              • Mark Harding
                Mark Harding @markeharding · 3 months ago
                Owner

                lets remove all changes to this file. I know we hack it for the languages but that is largely temporary.

              • Marcelo Rivera @eiennohi changed this line in version 3 of the diff 3 months ago

                changed this line in version 3 of the diff

              • Marcelo Rivera
                Marcelo Rivera @eiennohi · 3 months ago
                Developer

                I just moved this check to FeaturesService

              • Please register or sign in to reply
            • Marcelo Rivera @eiennohi added 1 commit 3 months ago

              added 1 commit

              • b9c7d422 - (fix): moved canary check on log in to FeaturesService

              Compare with previous version

            • Mark Harding @markeharding added MR::Awaiting Review scoped label 1 month ago

              added MR::Awaiting Review scoped label

            • Mark Harding @markeharding added Squad::Yellow scoped label 2 weeks ago

              added Squad::Yellow scoped label

            • Mark Harding
              Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
              Resolved by Marcelo Rivera 11 minutes ago
            • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 week ago

              added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

            • Mark Harding
              Mark Harding @markeharding · 1 day ago
              Owner

              @eiennohi did we forget about this? Please follow up with merge requests.

            • Marcelo Rivera @eiennohi added 483 commits 12 minutes ago

              added 483 commits

              • b9c7d422...12578c8b - 481 commits from branch minds:master
              • 46a2631d - Merge remote-tracking branch 'upstream/master' into...
              • 73ff7e5a - (fix): removed unnecessary reload

              Compare with previous version

            • Marcelo Rivera @eiennohi mentioned in issue #1630 11 minutes ago

              mentioned in issue #1630

            • Marcelo Rivera @eiennohi changed the description 10 minutes ago

              changed the description

            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
            Please register or sign in to reply
            0 Assignees
            None
            Assign to
            None
            Milestone
            None
            Assign milestone
            None
            Time tracking
            No estimate or time spent
            2
            Labels
            MR::Requires Changes Squad::Yellow
            Assign labels
            • View project labels
            Lock merge request
            Unlocked
            2
            2 participants
            user avatar
            Marcelo Rivera
            user avatar
            Mark Harding
            Reference: minds/front!211