Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 842
    • Issues 842
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 42
    • Merge Requests 42
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !446

Closed
Opened 3 weeks ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

WIP: [Sprint/InterestingIguana](bug): Pause video when scrolled offscreen #1418

Closes #1418

Need to test this in staging.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/offscreen-pause-video-1418 origin/feat/offscreen-pause-video-1418

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff feat/offscreen-pause-video-1418

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/offscreen-pause-video-1418 into master
  • Email patches
  • Plain diff
Pipeline #70798997 passed for 9b3afbb7 on feat/offscreen-pause-video-1418
          Requires 2 more approvals from Devs and Deployers.
          Emiliano Balbuena
          Emiliano Balbuena
          Marcelo Rivera
          Marcelo Rivera
          Mark Harding
          Mark Harding
          Martin Santangelo
          Martin Santangelo
          Brian Hatchet
          Brian Hatchet

          Closed by Ben Hayward 7 minutes ago

          The changes were not merged into master

          Did not close #1418

          Deletes source branch

          • Discussion 8
          • Commits 4
          • Pipelines 4
          • Changes 1
          3/4 threads resolved
          • Loading...
          • Mark Harding @markeharding added MR::Requires Changes scoped label 2 weeks ago

            added MR::Requires Changes scoped label

          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 2 weeks ago
            Resolved by Ben Hayward 2 weeks ago
          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 2 weeks ago
            Resolved by Ben Hayward 2 weeks ago
          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 2 weeks ago
            Last updated by Ben Hayward 2 weeks ago
            src/app/modules/media/components/video/video.component.ts
            28 28 @ViewChild('progressBar', { static: false }) progressBar: MindsVideoProgressBar;
            29 29 @ViewChild('volumeSlider', { static: false }) volumeSlider: MindsVideoVolumeSlider;
            30 30 @ViewChild('player', { static: false }) playerRef: MindsPlayerInterface;
            31 @ViewChild('playButton', { static: false }) playButton: ElementRef;
            32
            33 @HostListener('window:scroll')
            34 checkScroll() {
            35 if (!this.isInView(this.playButton.nativeElement) && this.playerRef.isPlaying()) {
            • Mark Harding
              Mark Harding @markeharding · 2 weeks ago
              Owner

              Should we not just call pause in all scenarios?

            • Ben Hayward
              Ben Hayward @benhayward.ben · 2 weeks ago
              Developer

              Not sure what you mean, can you elaborate?

            • Ben Hayward @benhayward.ben changed this line in version 2 of the diff 2 weeks ago

              changed this line in version 2 of the diff

            • Please register or sign in to reply
          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 2 weeks ago
            Resolved by Ben Hayward 2 weeks ago
          • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

            added 1 commit

            • 81deca1c - Update for feedback

            Compare with previous version

          • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

            added 1 commit

            • 8c029ded - Commenting out lines

            Compare with previous version

          • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

            added 1 commit

            • 9b3afbb7 - Spacing issues

            Compare with previous version

          • Ben Hayward
            Ben Hayward @benhayward.ben · 2 weeks ago
            Developer

            Need to get the AWS configs into the sandbox when I manage to fix up k8s, unless somebody else wants to take a whack for me.

          • Mark Harding @markeharding added Squad::Green scoped label 2 weeks ago

            added Squad::Green scoped label

          • Ben Hayward @benhayward.ben closed 7 minutes ago

            closed

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Requires Changes Squad::Green
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          6
          6 participants
          user avatar
          Emiliano Balbuena
          user avatar
          Marcelo Rivera
          user avatar
          Mark Harding
          user avatar
          Martin Santangelo
          user avatar
          Brian Hatchet
          user avatar
          Ben Hayward
          Reference: minds/front!446