Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 833
    • Issues 833
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 43
    • Merge Requests 43
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Issues
  • #1608

Closed
Open
Opened 1 hour ago by Brian Hatchet@brianhatchet:speech_balloon:
  • Report abuse
  • New issue
Report abuse New issue

(chore) create a pre-commit or gitlab step that prevents checking in of fit and fdescribe

It's far too easy to check in an fit or fdescribe in our front end unit tests.

Probably a little script to regex .spec.ts will sufficient and bomb out if it finds ones

Please solve the reCAPTCHA

We want to be sure it is you, please confirm you are not a robot.

Related issues
0

    • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %sprint: Kilted Koala 1 hour ago

      changed milestone to %sprint: Kilted Koala

    • Brian Hatchet :speech_balloon: @brianhatchet added Squad::Green scoped label 1 hour ago

      added Squad::Green scoped label

    • Brian Hatchet :speech_balloon: @brianhatchet changed weight to 5 1 hour ago

      changed weight to 5

    • Ben Hayward
      Ben Hayward @benhayward.ben · 56 minutes ago
      Developer

      Dupe, closed minds#694 (closed) for this.

      Please do check out the description though as there was a couple of suggestions

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    Ben Hayward's avatar Ben Hayward @benhayward.ben
    Assign to
    None
    Epic
    None
    sprint: Kilted Koala
    Milestone
    sprint: Kilted Koala
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    None
    Due date
    None
    1
    Labels
    Squad::Green
    Assign labels
    • View project labels
    5
    Weight
    5
    Confidentiality
    Not confidential
    Lock issue
    Unlocked
    2
    2 participants
    user avatar
    Ben Hayward
    user avatar
    Brian Hatchet
    Reference: minds/front#1608