Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 185
    • Issues 185
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 31
    • Merge Requests 31
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Issues
  • #458

Closed
Open
Opened 3 months ago by Jake Passi@JakePassi
  • Report abuse
  • New issue
Report abuse New issue

(bug): Retrospectively paywalled posts do not apply the paywall to attachements

Summary

The problem is they can access paywalled images, videos and blogs by simply clicking on the thumbnail in the gallery widget or by viewing the gallery and then clicking the thumbnail.

NOTE: Canary mode is turned on.

See for example on https://www.minds.com/bhayward Image https://www.minds.com/media/977926766784184320

Steps to reproduce

  1. Go to the channel for your primary account.
  2. Click "Attach" and upload an image.
  3. Click "Post".
  4. Edit the post.
  5. Put it behind a 1 token paywall.
  6. Log out and log in to your secondary account.
  7. Visit channel for your primary account.
  8. Scroll down to the image gallery widget.
  9. Click "View More".
  10. Click on the thumbnail for the image.

Platform information

  • Windows 10 / Chrome (Version 73.0.3683.86)
  • replicated Manjaro / Chromium

What is the current bug behavior?

When you post an image, video or blog and then put it behind a paywall, it is still visible in your image/video/blog gallery for other users.

What is the expected correct behavior?

If you put an image/video/blog behind a paywall after you already posted it to your channel, it shouldn't be visible and accessible to users who do not meet the paywall threshold for that content. Either that or it should appear for other users but behind the paywall mask and I think both you and other users should be able to filter the image/video/blog gallery by paywalled content. Perhaps just add a button called "Exclusive Content" at the top of each gallery.

Relevant logs and/or screenshots

image image

Video

https://imgur.com/yRzqylz

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

Please solve the reCAPTCHA

We want to be sure it is you, please confirm you are not a robot.

Edited 2 months ago by Ben Hayward

Related issues
0

    Related merge requests
    1
    • Merged 3 weeks ago
      Jul 5, 2019 8:39am GMT+0000
      (fix): Attachment should inherit wire threshold on edit (#458)
      Merged 3 weeks ago
      Jul 5, 2019 8:39am GMT+0000
      !181
      Avatar for Emiliano Balbuena
      Assignee Emiliano Balbuena @edgebal
      Avatar for Emiliano Balbuena
      Assignee Emiliano Balbuena @edgebal
    • Jake Passi @JakePassi added 1 - High P - Media P - Newsfeed T - Bug scoped labels 3 months ago

      added 1 - High P - Media P - Newsfeed T - Bug scoped labels

    • Bill Ottman :dragon_face: @ottman added to epic &15 3 months ago

      added to epic &15

    • Mark Harding
      Mark Harding @markeharding · 2 months ago
      Owner

      Tested on wrong subdomain.

      @benhayward.ben please confirm this bug

    • Mark Harding @markeharding changed milestone to %sprint: Funny Frog 2 months ago

      changed milestone to %sprint: Funny Frog

    • Mark Harding @markeharding added S - Backlog scoped label 2 months ago

      added S - Backlog scoped label

    • Mark Harding @markeharding changed weight to 2 2 months ago

      changed weight to 2

    • Ben Hayward
      Ben Hayward @benhayward.ben · 2 months ago
      Developer

      Yeah it is @markeharding just replicated Manjaro / Chromium

    • Mark Harding
      Mark Harding @markeharding · 2 months ago
      Owner

      Please post links and populate this ticket

    • Ben Hayward
      Ben Hayward @benhayward.ben · 2 months ago
      Developer

      It's populated already, the steps but I've added in my evidence of it.

    • Ben Hayward @benhayward.ben changed the description 3 times within 3 minutes 2 months ago

      changed the description 3 times within 3 minutes

    • Mark Harding
      Mark Harding @markeharding · 2 months ago
      Owner

      @benhayward.ben I don't see a single link above

    • Ben Hayward @benhayward.ben changed the description 2 months ago

      changed the description

    • Ben Hayward
      Ben Hayward @benhayward.ben · 2 months ago
      Developer

      2 images and a video up there, the video is quite hidden though. Included a link to my test profile where you can see the issue occurring

    • Mark Harding
      Mark Harding @markeharding · 2 months ago
      Owner

      Lets put as many links in as possible. Which images should be behind the paywalls? Where are there respective newsfeed links?

    • Mark Harding @markeharding assigned to @edgebal 2 months ago

      assigned to @edgebal

    • Mark Harding @markeharding changed title from (bug): When you post an image, video or blog and then put it behind a paywall, it is still visible in your image/video/blog gallery for other users. to (bug): Retrospectively paywalled posts do not apply the paywall to attachements 2 months ago

      changed title from (bug): When you post an image, video or blog and then put it behind a paywall, it is still visible in your image/video/blog gallery for other users. to (bug): Retrospectively paywalled posts do not apply the paywall to attachements

    • Mark Harding
      Mark Harding @markeharding · 2 months ago
      Owner

      @edgebal - I think we need to ensure that if a paywall is added in on edit (for an already existing post) that we sync the paywall with any attached entities.

    • Ben Hayward
      Ben Hayward @benhayward.ben · 2 months ago
      Developer

      I think we may be confusing two issues here @markeharding

    • Ben Hayward
      Ben Hayward @benhayward.ben · 2 months ago
      Developer

      This one, is that the content still shows in the gallery without a filter. e.g. here image

      The arrows are pointing to the same entity - that post, that when unlocked is a randomly picked image of a phone, is visible to any user who does not pay me.

      Edited by Ben Hayward 2 months ago
    • Mark Harding
      Mark Harding @markeharding · 2 months ago
      Owner

      Ok well we still need links so we are on the same page. The steps imply that this only happens when a post is edited retrospectively and not at the time of creation.

    • Ben Hayward @benhayward.ben changed the description 2 months ago

      changed the description

    • Ben Hayward
      Ben Hayward @benhayward.ben · 2 months ago
      Developer

      Yep, just tested to confirm, this is only happening on edit. Updated with links to the image and profile where you can see it happening.

    • Emiliano Balbuena @edgebal changed milestone to %sprint: Funny Frog 2 months ago

      changed milestone to %sprint: Funny Frog

    • Emiliano Balbuena @edgebal changed weight to 2 2 months ago

      changed weight to 2

    • Emiliano Balbuena @edgebal moved from front#950 (closed) 2 months ago

      moved from front#950 (closed)

    • Emiliano Balbuena @edgebal added S - InProgress scoped label and automatically removed S - Backlog label 2 months ago

      added S - InProgress scoped label and automatically removed S - Backlog label

    • Emiliano Balbuena @edgebal changed weight to 3 2 months ago

      changed weight to 3

    • Emiliano Balbuena @edgebal mentioned in merge request !181 (merged) 2 months ago

      mentioned in merge request !181 (merged)

    • Emiliano Balbuena @edgebal mentioned in issue #478 (closed) 2 months ago

      mentioned in issue #478 (closed)

    • Mark Harding @markeharding changed milestone to %sprint: Giddy Giraffe 1 month ago

      changed milestone to %sprint: Giddy Giraffe

    • Mark Harding @markeharding added S - Backlog scoped label and automatically removed S - Review label 1 month ago

      added S - Backlog scoped label and automatically removed S - Review label

    • Emiliano Balbuena @edgebal added S - Review scoped label and automatically removed S - Backlog label 1 month ago

      added S - Review scoped label and automatically removed S - Backlog label

    • Emiliano Balbuena @edgebal changed milestone to %sprint: Hipster Hedgehog 1 month ago

      changed milestone to %sprint: Hipster Hedgehog

    • Emiliano Balbuena @edgebal added Status::Follow Up scoped label and automatically removed Status::Review label 1 month ago

      added Status::Follow Up scoped label and automatically removed Status::Review label

    • Mark Harding @markeharding removed from epic &15 3 weeks ago

      removed from epic &15

    • Emiliano Balbuena @edgebal changed milestone to %sprint: Interesting Iguana 3 weeks ago

      changed milestone to %sprint: Interesting Iguana

    • Emiliano Balbuena @edgebal mentioned in commit b2157244 3 weeks ago

      mentioned in commit b2157244

    • Mark Harding @markeharding mentioned in commit 4c28ed54 3 weeks ago

      mentioned in commit 4c28ed54

    • Mark Harding @markeharding added Squad::Yellow scoped label 1 week ago

      added Squad::Yellow scoped label

    • Emiliano Balbuena @edgebal closed 1 hour ago

      closed

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    Emiliano Balbuena's avatar Emiliano Balbuena @edgebal
    Assign to
    None
    Epic
    None
    sprint: Interesting Iguana
    Milestone
    sprint: Interesting Iguana
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    None
    Due date
    None
    6
    Labels
    Priority::1 - High Product::Media Product::Newsfeed Squad::Yellow Status::Follow Up Type::Bug
    Assign labels
    • View project labels
    3
    Weight
    3
    Confidentiality
    Not confidential
    Lock issue
    Unlocked
    5
    5 participants
    user avatar
    Emiliano Balbuena
    user avatar
    Mark Harding
    user avatar
    Ben Hayward
    user avatar
    Bill Ottman
    user avatar
    Jake Passi
    Reference: minds/engine#458