(bug): Retrospectively paywalled posts do not apply the paywall to attachements
Summary
The problem is they can access paywalled images, videos and blogs by simply clicking on the thumbnail in the gallery widget or by viewing the gallery and then clicking the thumbnail.
NOTE: Canary mode is turned on.
See for example on https://www.minds.com/bhayward Image https://www.minds.com/media/977926766784184320
Steps to reproduce
- Go to the channel for your primary account.
- Click "Attach" and upload an image.
- Click "Post".
- Edit the post.
- Put it behind a 1 token paywall.
- Log out and log in to your secondary account.
- Visit channel for your primary account.
- Scroll down to the image gallery widget.
- Click "View More".
- Click on the thumbnail for the image.
Platform information
- Windows 10 / Chrome (Version 73.0.3683.86)
- replicated Manjaro / Chromium
What is the current bug behavior?
When you post an image, video or blog and then put it behind a paywall, it is still visible in your image/video/blog gallery for other users.
What is the expected correct behavior?
If you put an image/video/blog behind a paywall after you already posted it to your channel, it shouldn't be visible and accessible to users who do not meet the paywall threshold for that content. Either that or it should appear for other users but behind the paywall mask and I think both you and other users should be able to filter the image/video/blog gallery by paywalled content. Perhaps just add a button called "Exclusive Content" at the top of each gallery.
Relevant logs and/or screenshots
Video
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)
- added 1 - High P - Media P - Newsfeed T - Bug scoped labels 
- OwnerTested on wrong subdomain. @benhayward.ben please confirm this bug 
- changed milestone to %sprint: Funny Frog 
- added S - Backlog scoped label 
- changed weight to 2 
- DeveloperYeah it is @markeharding just replicated Manjaro / Chromium 
- OwnerPlease post links and populate this ticket 
- DeveloperIt's populated already, the steps but I've added in my evidence of it. 
- changed the description 3 times within 3 minutes 
- Owner@benhayward.ben I don't see a single link above 
- changed the description 
- Developer2 images and a video up there, the video is quite hidden though. Included a link to my test profile where you can see the issue occurring 
- OwnerLets put as many links in as possible. Which images should be behind the paywalls? Where are there respective newsfeed links? 
- assigned to @edgebal 
- changed title from (bug): When you post an image, video or blog and then put it behind a paywall, it is still visible in your image/video/blog gallery for other users. to (bug): Retrospectively paywalled posts do not apply the paywall to attachements 
- Owner@edgebal - I think we need to ensure that if a paywall is added in on edit (for an already existing post) that we sync the paywall with any attached entities. 
- DeveloperI think we may be confusing two issues here @markeharding 
- DeveloperThis one, is that the content still shows in the gallery without a filter. e.g. here The arrows are pointing to the same entity - that post, that when unlocked is a randomly picked image of a phone, is visible to any user who does not pay me. Edited by Ben Hayward
- OwnerOk well we still need links so we are on the same page. The steps imply that this only happens when a post is edited retrospectively and not at the time of creation. 
- changed the description 
- DeveloperYep, just tested to confirm, this is only happening on edit. Updated with links to the image and profile where you can see it happening. 
- changed milestone to %sprint: Funny Frog 
- changed weight to 2 
- moved from front#950 (closed) 
- added S - InProgress scoped label and automatically removed S - Backlog label 
- changed weight to 3 
- mentioned in merge request !181 (merged) 
- mentioned in issue #478 (closed) 
- changed milestone to %sprint: Giddy Giraffe 
- added S - Backlog scoped label and automatically removed S - Review label 
- added S - Review scoped label and automatically removed S - Backlog label 
- changed milestone to %sprint: Hipster Hedgehog 
- added Status::Follow Up scoped label and automatically removed Status::Review label 
- removed from epic &15 
- changed milestone to %sprint: Interesting Iguana 
- mentioned in commit 4c28ed54 
- added Squad::Yellow scoped label 
- closed