Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 847
    • Issues 847
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 45
    • Merge Requests 45
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !468

Open
Opened 2 hours ago by Olivia Madrid@omadrid
  • Report abuse
Report abuse

(chore): Dark mode audit

Cleaned up colors that weren't themed, fixed blue-light/blue-dark mapping

Closes #1553

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/dark-mode-audit-1553 origin/feat/dark-mode-audit-1553

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff feat/dark-mode-audit-1553

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/dark-mode-audit-1553 into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #73639424 passed for e637b3f4 on feat/dark-mode-audit-1553
          Requires 2 more approvals from Devs and Deployers.
          Mark Harding
          Mark Harding
          Martin Santangelo
          Martin Santangelo
          Emiliano Balbuena
          Emiliano Balbuena
          Marcelo Rivera
          Marcelo Rivera
          Brian Hatchet
          Brian Hatchet
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #1553

          • Discussion 1
          • Commits 1
          • Pipelines 1
          • Changes 27
          0/1 thread resolved
          • Loading...
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 9 minutes ago
            src/app/common/components/android-app-download-button/button.component.scss
            1 1 .m-androidApp__download {
            2 2 box-sizing: border-box;
            3 border: 2px solid rgba(255,255,255,0.6);
            4 3 border-radius: 8px;
            5 background: #111;
            4 @include m-theme(){
            5 border: 2px solid rgba(themed($m-white), 0.6);
            6 background: rgba(themed($m-grey-950), 0.7);
            • Mark Harding
              Mark Harding @markeharding · 9 minutes ago
              Owner

              I think we always want the android button to be black background and white text, not to invert.

              Edited by Mark Harding 9 minutes ago
            • Please register or sign in to reply
          • Mark Harding @markeharding added MR::Requires Changes Squad::Blue scoped labels 8 minutes ago

            added MR::Requires Changes Squad::Blue scoped labels

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Requires Changes Squad::Blue
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          7
          7 participants
          user avatar
          Mark Harding
          user avatar
          Martin Santangelo
          user avatar
          Emiliano Balbuena
          user avatar
          Marcelo Rivera
          user avatar
          Brian Hatchet
          user avatar
          Ben Hayward
          user avatar
          Olivia Madrid
          Reference: minds/front!468