WIP: [Sprint/GiddyGiraffe](feat): Added in buttons for play store and ios #613
Edited by Ben Hayward
Closed by 
The changes were not merged into master
changed the description
38 39 this.detectChanges(); 39 40 40 41 this.releases = await this.service.getReleases(); 42 this.latestUrl = this.releases[0].href; 
DeveloperTake in account that there are Canary releases listed in the remote JSON. Sync with @msantang78 to ensure you're not offering the Canary version to people who've not opted in. Maybe it's best to
.filter()the releases array before you grab the0index.
7 8 8 9 <div class="m-marketing--hero--inner"> 9 10 10 <div class="m-marketing--hero--slogans"> 11 12 11 <h2> 13 Minds Android App 12 Minds Mobile App 14 13 </h2> 15 16 14 </div> 17 18 15 <div class="m-marketing--hero--actions"> 19 <i class="material-icons m-mobile__giantDroid">android</i> 16 <div class="m-marketing--hero--logos"> - Developer
Maybe we can disable the button (or hide it) until
latestUrlhas a value. If the user has lag (which might happen because they're on the cellphone) they will be taken tominds.com/mobile/undefined.
added MR::Requires Changes scoped label
12 Minds Mobile App 14 13 </h2> 15 16 14 </div> 17 18 15 <div class="m-marketing--hero--actions"> 19 <i class="material-icons m-mobile__giantDroid">android</i> 16 <div class="m-marketing--hero--logos"> 17 <img [src]="minds.cdn_assets_url + 'assets/logos/bulb.svg'"> 18 </div> 19 <div class="mdl-card__supporting-text m-marketing--section--downloadContainer"> 20 <a href="https://geo.itunes.apple.com/us/app/minds-com/id961771928?mt=8&uo=6" target="_blank"> 21 <img class="m-marketing--section--downloadButton m-marketing--section--downloadButton--ios" 22 src="https://devimages-cdn.apple.com/app-store/marketing/guidelines/images/badge-download-on-the-app-store.svg"/> 23 </a> 24 <a [href]="latestUrl"> 
OwnerUse the current android button component on the homepage etc.
- Owner
I think we can improve this design wise. The SEO has a nice image which I think we should use. Also, consider moving all the app store links to the right sidebar. Mockups would be better before we hit any code.
- Developer
Passed this over to @jotto141 for some wireframes
added Squad::Green scoped label
marked as a Work In Progress
- Developer
Closing this MR as its going to be best to work off of a fresh slate when we get wireframes.
closed