Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 846
    • Issues 846
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 47
    • Merge Requests 47
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !178

Open
Opened 4 months ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/Users](bug): Updates to fix 'Enter phone number' modal on some mobiles

Closing #391 Tried to ensure I hadn't inadvertently changed another class using these files - Couldn't find anything, let me know if any were missed.

Screenshot_20190308-154215_Brave

Edited 4 months ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git enter-mobile-modal-css-fix--mobile
git checkout -b benhayward.ben/front-enter-mobile-modal-css-fix--mobile FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-enter-mobile-modal-css-fix--mobile

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:enter-mobile-modal-css-fix--mobile into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #73381112 canceled for 17027f6b on benhayward.ben:enter-mobile-modal-css-fix--mobile
          Requires approval.
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #391

          • Discussion 2
          • Commits 7
          • Pipelines 6
          • Changes 3
          • Loading...
          • Ben Hayward @benhayward.ben added 1 commit 4 months ago

            added 1 commit

            • 05291030 - Update phone-input.component.scss

            Compare with previous version

          • Ben Hayward @benhayward.ben added 1 commit 4 months ago

            added 1 commit

            • 40dcdd84 - Update onboarding.component.scss

            Compare with previous version

          • Ben Hayward @benhayward.ben changed the description 4 months ago

            changed the description

          • Mark Harding
            Mark Harding @markeharding · 4 months ago
            Owner

            Looks like we are still on a different line and its overflowing?

          • Ben Hayward @benhayward.ben added 13 commits 4 months ago

            added 13 commits

            • 40dcdd84...60091f87 - 11 commits from branch minds:master
            • 100d7903 - Merge branch 'master' of gitlab.com:benhayward.ben/front into enter-mobile-modal-css-fix--mobile
            • bce722dc - Making sure the input container is fixed to 100 width

            Compare with previous version

          • Ben Hayward
            Ben Hayward @benhayward.ben · 4 months ago
            Developer

            @markeharding forced max width to 100%. Were you meaning to put the button on the same line? I prefer it below on mobile because it lines up nicely with the purchase button, but could further save space I suppose. Let me know.

          • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label 3 weeks ago

            added MR::Awaiting Review scoped label

          • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 2 weeks ago

            added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

          • Ben Hayward @benhayward.ben added 523 commits 2 weeks ago

            added 523 commits

            • bce722dc...3fad9777 - 522 commits from branch minds:master
            • e3226b71 - Merge branch 'master' into 'enter-mobile-modal-css-fix--mobile'

            Compare with previous version

          • Mark Harding @markeharding added Squad::Green scoped label 1 week ago

            added Squad::Green scoped label

          • Ben Hayward @benhayward.ben added 40 commits 4 hours ago

            added 40 commits

            • e3226b71...bb8e6d9b - 39 commits from branch minds:master
            • 17027f6b - Merge branch 'master' into 'enter-mobile-modal-css-fix--mobile'

            Compare with previous version

          • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 4 hours ago

            added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

          • Ben Hayward @benhayward.ben closed 4 hours ago

            closed

          • Ben Hayward @benhayward.ben reopened 4 hours ago

            reopened

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Awaiting Review Squad::Green
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          2
          2 participants
          user avatar
          Ben Hayward
          user avatar
          Mark Harding
          Reference: minds/front!178