Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 845
    • Issues 845
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 47
    • Merge Requests 47
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !465

Open
Opened 59 minutes ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/JollyJellyfish](bug): Fixed issue causing notifications to mem leak out and break

Closes #1594

To test please follow steps in the issue, and check out that notifications are working correctly.

image

Edited 59 minutes ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/notifications-breaking-boost-reject-1594 origin/fix/notifications-breaking-boost-reject-1594

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix/notifications-breaking-boost-reject-1594

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/notifications-breaking-boost-reject-1594 into master
The source branch is 2 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #73377261 failed for 2b0a6df7 on fix/notifications-breaking-boost-reject-1594
          Requires 2 more approvals from Devs and Deployers.
          Martin Santangelo
          Martin Santangelo
          Mark Harding
          Mark Harding
          Brian Hatchet
          Brian Hatchet
          Emiliano Balbuena
          Emiliano Balbuena
          Marcelo Rivera
          Marcelo Rivera
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #1594

          Deletes source branch

          • Discussion 0
          • Commits 1
          • Pipelines 1
          • Changes 1
          • Loading...
          • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Green scoped labels 59 minutes ago

            added MR::Awaiting Review Squad::Green scoped labels

          • Ben Hayward @benhayward.ben changed title from Fixed issue causing notifications to mem leak out and break to {+Sprint/JollyJellyfish: +}Fixed issue causing notifications to mem leak out and break 59 minutes ago

            changed title from Fixed issue causing notifications to mem leak out and break to {+Sprint/JollyJellyfish: +}Fixed issue causing notifications to mem leak out and break

          • Ben Hayward @benhayward.ben changed the description 59 minutes ago

            changed the description

          • Ben Hayward @benhayward.ben mentioned in issue minds#704 (closed) 42 minutes ago

            mentioned in issue minds#704 (closed)

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Awaiting Review Squad::Green
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          6
          6 participants
          user avatar
          Martin Santangelo
          user avatar
          Mark Harding
          user avatar
          Brian Hatchet
          user avatar
          Emiliano Balbuena
          user avatar
          Marcelo Rivera
          user avatar
          Ben Hayward
          Reference: minds/front!465