Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 185
    • Issues 185
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 32
    • Merge Requests 32
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !280

Merged
Opened 1 week ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/JollyJellyfish](bug): Plus not working locally #655

Used here https://gitlab.com/minds/engine/blob/51618b7d4d1260e65cd0ef022ca51f17189ef8f5/Core/Wire/Delegates/Plus.php#L36

Request to merge patch-1 into master
  • Email patches
  • Plain diff
Pipeline #71985311 passed with warnings for e7a91267 on patch-1
          Merge request approved. Approved by
          Mark Harding
          Mark Harding
          Brian Hatchet
          Brian Hatchet
          Marcelo Rivera
          Marcelo Rivera
          Rami Albatal
          Rami Albatal
          Emiliano Balbuena
          Emiliano Balbuena
          Martin Santangelo
          Martin Santangelo

          Merged by Mark Harding 8 hours ago

          The changes were merged into master with 81ed3601

          The source branch has been deleted

          Mentions #655

          Pipeline #73269623 passed for 81ed3601 on master
                  • Discussion 2
                  • Commits 2
                  • Pipelines 2
                  • Changes 1
                  • Loading...
                  • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label 5 days ago

                    added MR::Awaiting Review scoped label

                  • Marcelo Rivera @eiennohi approved this merge request 5 days ago

                    approved this merge request

                  • Ben Hayward @benhayward.ben added Squad::Green scoped label 5 days ago

                    added Squad::Green scoped label

                  • Brian Hatchet
                    Brian Hatchet :speech_balloon: @brianhatchet · 5 days ago
                    Maintainer

                    How can I test this?

                  • Brian Hatchet
                    Brian Hatchet :speech_balloon: @brianhatchet · 2 days ago
                    Maintainer

                    Let's get this configured to be runnable on the staging environment. We'll need the plus values to be configured to test anyway. Just set the defaults in the configuration.yamls and make sure we set the production ones in the production yaml

                  • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 day ago

                    approved this merge request

                  • Mark Harding @markeharding approved this merge request 8 hours ago

                    approved this merge request

                  • Mark Harding @markeharding merged 8 hours ago

                    merged

                  • Mark Harding @markeharding mentioned in commit 81ed3601 8 hours ago

                    mentioned in commit 81ed3601

                  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                  Please register or sign in to reply
                  0 Assignees
                  None
                  Assign to
                  None
                  Milestone
                  None
                  Assign milestone
                  None
                  Time tracking
                  No estimate or time spent
                  2
                  Labels
                  MR::Awaiting Review Squad::Green
                  Assign labels
                  • View project labels
                  Lock merge request
                  Unlocked
                  7
                  7 participants
                  user avatar
                  Rami Albatal
                  user avatar
                  Emiliano Balbuena
                  user avatar
                  Martin Santangelo
                  user avatar
                  Mark Harding
                  user avatar
                  Brian Hatchet
                  user avatar
                  Marcelo Rivera
                  user avatar
                  Ben Hayward
                  Reference: minds/engine!280

                  Revert this merge request

                  This will create a new commit in order to revert the existing changes.

                  Switch branch
                  Cancel
                  A new branch will be created in your fork and a new merge request will be started.

                  Cherry-pick this merge request

                  Switch branch
                  Cancel
                  A new branch will be created in your fork and a new merge request will be started.