Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Mobile
Minds Mobile
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 122
    • Issues 122
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 16
    • Merge Requests 16
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • Minds
  • Minds MobileMinds Mobile
  • Merge Requests
  • !278

Open
Opened 1 hour ago by Martin Santangelo@msantang782 of 3 tasks completed2/3 tasks
  • Report abuse
Report abuse

WIP: [Sprint/JollyJellyfish] (feat) reimplement boost injector for offline first

  • Reimplement boost injector for offline first
  • Inject boosts in the main newsfeed and discovery all
  • Spec test

This new implementation is cleaner than the previous one, to use it we only need to call setInjectBoost(true) into the feed store.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/msantang78/mobile-native.git sprint/JollyJellyfish.feat.reimplement.boost.injector.offline-first
git checkout -b msantang78/mobile-native-sprint/JollyJellyfish.feat.reimplement.boost.injector.offline-first FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff msantang78/mobile-native-sprint/JollyJellyfish.feat.reimplement.boost.injector.offline-first

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge msantang78:sprint/JollyJellyfish.feat.reimplement.boost.injector.offline-first into master
Open in Web IDE
  • Email patches
  • Plain diff
Could not retrieve the pipeline status. For troubleshooting steps, read the documentation.
Requires 2 more approvals.
This is a Work in Progress
You can merge this merge request manually using the
  • Discussion 0
  • Commits 1
  • Pipelines 1
  • Changes 5
  • Loading...
  • Martin Santangelo @msantang78 changed milestone to %sprint: Jolly Jellyfish 1 hour ago

    changed milestone to %sprint: Jolly Jellyfish

  • Martin Santangelo @msantang78 added Squad::Green scoped label 1 hour ago

    added Squad::Green scoped label

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
0 Assignees
None
Assign to
sprint: Jolly Jellyfish
Milestone
sprint: Jolly Jellyfish
Assign milestone
None
Time tracking
No estimate or time spent
1
Labels
Squad::Green
Assign labels
  • View project labels
Lock merge request
Unlocked
1
1 participant
user avatar
Martin Santangelo
Reference: minds/mobile-native!278