Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Mobile
Minds Mobile
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 122
    • Issues 122
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 15
    • Merge Requests 15
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • Minds
  • Minds MobileMinds Mobile
  • Merge Requests
  • !272

Open
Opened 2 days ago by Martin Santangelo@msantang78
  • Report abuse
Report abuse

[Sprint/JollyJellyfish] (fix) no subs count on channels

closes #1119

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/msantang78/mobile-native.git sprint/JollyJellyfish.fix.no.subs-count.in.channels
git checkout -b msantang78/mobile-native-sprint/JollyJellyfish.fix.no.subs-count.in.channels FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/v3.8.0-rc2
git merge --no-ff msantang78/mobile-native-sprint/JollyJellyfish.fix.no.subs-count.in.channels

Step 4. Push the result of the merge to GitLab

git push origin v3.8.0-rc2

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge msantang78:sprint/JollyJellyfish.fix.no.subs-count.in.channels into v3.8.0-rc2
Open in Web IDE
  • Email patches
  • Plain diff
Could not retrieve the pipeline status. For troubleshooting steps, read the documentation.
Requires 2 more approvals.
Ready to be merged automatically. Ask someone with write access to this repository to merge this request
  • Discussion 2
  • Commits 2
  • Pipelines 2
  • Changes 4
0/1 thread resolved
  • Loading...
  • Martin Santangelo @msantang78 changed milestone to %sprint: Jolly Jellyfish 2 days ago

    changed milestone to %sprint: Jolly Jellyfish

  • Martin Santangelo @msantang78 added Squad::Green scoped label 2 days ago

    added Squad::Green scoped label

  • Martin Santangelo @msantang78 changed target branch from master to v3.8.0-rc2 1 day ago

    changed target branch from master to v3.8.0-rc2

  • Brian Hatchet
    Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 1 day ago
    Last updated by Martin Santangelo 1 hour ago
    __tests__/blogs/__snapshots__/BlogsViewScreen.js.snap
    75 75 "getAvatarSource": [MockFunction],
    76 76 "guid": 100,
    77 77 "icontime": "1523515420",
    78 "impressions": undefined,
    • Brian Hatchet
      Brian Hatchet :speech_balloon: @brianhatchet · 1 day ago
      Maintainer

      Are these supposed to be undefined?

    • Martin Santangelo
      Martin Santangelo @msantang78 · 1 hour ago
      Maintainer

      I will add that field to the BlogsFaker

    • Please register or sign in to reply
  • Martin Santangelo @msantang78 added MR::Awaiting Review scoped label 6 hours ago

    added MR::Awaiting Review scoped label

  • Martin Santangelo @msantang78 added 1 commit 1 hour ago

    added 1 commit

    • b30d2bb3 - (chore) update blogFaker

    Compare with previous version

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
0 Assignees
None
Assign to
sprint: Jolly Jellyfish
Milestone
sprint: Jolly Jellyfish
Assign milestone
None
Time tracking
No estimate or time spent
2
Labels
MR::Awaiting Review Squad::Green
Assign labels
  • View project labels
Lock merge request
Unlocked
2
2 participants
user avatar
Martin Santangelo
user avatar
Brian Hatchet
Reference: minds/mobile-native!272