Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Mobile
Minds Mobile
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 118
    • Issues 118
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 14
    • Merge Requests 14
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • Minds
  • Minds MobileMinds Mobile
  • Merge Requests
  • !249

Open
Opened 1 week ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/InterestingIguana](fix): Stopped rendering of undecrypted messages

Closes #887

janky_messenger_decrypt

image

Edited 55 minutes ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/mobile-native.git fix/decrypted-chat-hide-1083
git checkout -b benhayward.ben/mobile-native-fix/decrypted-chat-hide-1083 FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/mobile-native-fix/decrypted-chat-hide-1083

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:fix/decrypted-chat-hide-1083 into master
The source branch is 107 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #71363526 passed for aa55751d on benhayward.ben:fix/decrypted-chat-hide-1083
    Requires 2 more approvals.
    Ready to be merged automatically. Ask someone with write access to this repository to merge this request

    Allows commits from members who can merge to the target branch

    Closes #887

    Deletes source branch

    • Discussion 4
    • Commits 3
    • Pipelines 3
    • Changes 2
    • Loading...
    • Ben Hayward @benhayward.ben changed the description 1 week ago

      changed the description

    • Ben Hayward @benhayward.ben marked as a Work In Progress 1 week ago

      marked as a Work In Progress

    • Ben Hayward @benhayward.ben added 1 commit 1 week ago

      added 1 commit

      • aa55751d - Show a feint message when decrypt failed

      Compare with previous version

    • Ben Hayward @benhayward.ben changed the description 1 week ago

      changed the description

    • Brian Hatchet
      Brian Hatchet :speech_balloon: @brianhatchet · 1 week ago
      Maintainer

      Ok, I am going to need some help testing this one. Can you walk me through it?

    • Ben Hayward
      Ben Hayward @benhayward.ben · 1 week ago
      Developer

      Can do if you like when we get to it. Just restructuring this component a bit at the moment as per Martins specification in our chat.

    • Ben Hayward
      Ben Hayward @benhayward.ben · 1 week ago
      Developer

      The approvals aren't required for mobile-native but an extra pair of eyes is always welcomed.

    • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %sprint: Jolly Jellyfish 7 hours ago

      changed milestone to %sprint: Jolly Jellyfish

    • Ben Hayward @benhayward.ben unmarked as a Work In Progress 55 minutes ago

      unmarked as a Work In Progress

    • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Green scoped labels 55 minutes ago

      added MR::Awaiting Review Squad::Green scoped labels

    • Martin Santangelo
      Martin Santangelo @msantang78 · 7 minutes ago
      Maintainer

      Maybe we can move the decryption of the messages to the conversation store and run the decryption from the latest message to the oldest ones, once we hit the first decryption error we stop there and remove the other messages. In order to get the Messages re-rendered when the state change we should create a MessageModel with a decrypted observable

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    0 Assignees
    None
    Assign to
    sprint: Jolly Jellyfish
    Milestone
    sprint: Jolly Jellyfish
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    2
    Labels
    MR::Awaiting Review Squad::Green
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    3
    3 participants
    user avatar
    Martin Santangelo
    user avatar
    Ben Hayward
    user avatar
    Brian Hatchet
    Reference: minds/mobile-native!249