Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 178
    • Issues 178
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 30
    • Merge Requests 30
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !232

Open
Opened 3 weeks ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/HiperHedgehog](bug): Fixed forgot password validation

-subdomain=revolutionaryape

Fixed indentation while I was here.

Closes #560

Edited 5 days ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b forgot-password-validation-fix-560 origin/forgot-password-validation-fix-560

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff forgot-password-validation-fix-560

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge forgot-password-validation-fix-560 into master
The source branch is 110 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #71354722 passed for e358c0a3 on forgot-password-validation-fix-560
        Requires 2 more approvals from Devs.
        Rami Albatal
        Rami Albatal
        Mark Harding
        Mark Harding
        Brian Hatchet
        Brian Hatchet
        Marcelo Rivera
        Marcelo Rivera
        Martin Santangelo
        Martin Santangelo
        Ready to be merged automatically. Ask someone with write access to this repository to merge this request

        Closes #560

        Deletes source branch

        • Discussion 3
        • Commits 2
        • Pipelines 2
        • Changes 1
        1/1 thread resolved
        • Loading...
        • Mark Harding @markeharding added MR::Awaiting Review scoped label 3 weeks ago

          added MR::Awaiting Review scoped label

        • Marcelo Rivera @eiennohi approved this merge request 2 weeks ago

          approved this merge request

        • Mark Harding
          Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
          Resolved by Ben Hayward 1 week ago
        • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 week ago

          added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

        • Ben Hayward @benhayward.ben added 1 commit 1 week ago

          added 1 commit

          • e358c0a3 - Updated to use validate_password and fixed identation

          Compare with previous version

        • Ben Hayward @benhayward.ben changed the description 1 week ago

          changed the description

        • Ben Hayward @benhayward.ben resolved all threads 1 week ago

          resolved all threads

        • Ben Hayward
          Ben Hayward @benhayward.ben · 1 week ago
          Developer

          Getting a weird behavior where it redirects anyway locally so will need to wait to test when we have email set up on the pods

        • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 1 week ago

          added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

        • Mark Harding @markeharding added Squad::Green scoped label 1 week ago

          added Squad::Green scoped label

        • Ben Hayward @benhayward.ben changed the description 5 days ago

          changed the description

        • Mark Harding
          Mark Harding @markeharding · 29 minutes ago
          Owner

          I can't really see what has changed here because of the change in spaces.

        • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 29 minutes ago

          added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

        • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
        Please register or sign in to reply
        0 Assignees
        None
        Assign to
        None
        Milestone
        None
        Assign milestone
        None
        Time tracking
        No estimate or time spent
        2
        Labels
        MR::Requires Changes Squad::Green
        Assign labels
        • View project labels
        Lock merge request
        Unlocked
        7
        7 participants
        user avatar
        Rami Albatal
        user avatar
        Mark Harding
        user avatar
        Brian Hatchet
        user avatar
        Marcelo Rivera
        user avatar
        Martin Santangelo
        user avatar
        Emiliano Balbuena
        user avatar
        Ben Hayward
        Reference: minds/engine!232