Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 178
    • Issues 178
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 30
    • Merge Requests 30
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !62

Closed
Opened 6 months ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/MindsOne] (fix): don't allow empty comments

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/eiennohi/engine.git sprint/MindsOne.feat.dont-allow-empty-comments
git checkout -b eiennohi/engine-sprint/MindsOne.feat.dont-allow-empty-comments FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/goal.CommentThreads
git merge --no-ff eiennohi/engine-sprint/MindsOne.feat.dont-allow-empty-comments

Step 4. Push the result of the merge to GitLab

git push origin goal.CommentThreads

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge eiennohi:sprint/MindsOne.feat.dont-allow-empty-comments into goal.CommentThreads
  • Email patches
  • Plain diff
Pipeline #44174838 failed for 63385193 on eiennohi:sprint/MindsOne.feat.dont-allow-empty-comments
      Requires 2 more approvals from Devs and Deployers.
      Mark Harding
      Mark Harding
      Brian Hatchet
      Brian Hatchet
      Rami Albatal
      Rami Albatal
      Emiliano Balbuena
      Emiliano Balbuena
      Ben Hayward
      Ben Hayward

      Closed by Mark Harding 7 minutes ago

      The changes were not merged into goal.CommentThreads

      Allows commits from members who can merge to the target branch

      Deletes source branch

      • Discussion 0
      • Commits 1
      • Pipelines 1
      • Changes 1
      • Loading...
      • Mark Harding @markeharding added MR::Awaiting Review scoped label 3 weeks ago

        added MR::Awaiting Review scoped label

      • Mark Harding @markeharding added Squad::Yellow scoped label 1 week ago

        added Squad::Yellow scoped label

      • Mark Harding @markeharding closed 7 minutes ago

        closed

      • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
      Please register or sign in to reply
      0 Assignees
      None
      Assign to
      None
      Milestone
      None
      Assign milestone
      None
      Time tracking
      No estimate or time spent
      2
      Labels
      MR::Awaiting Review Squad::Yellow
      Assign labels
      • View project labels
      Lock merge request
      Unlocked
      7
      7 participants
      user avatar
      Mark Harding
      user avatar
      Brian Hatchet
      user avatar
      Rami Albatal
      user avatar
      Emiliano Balbuena
      user avatar
      Ben Hayward
      user avatar
      Martin Santangelo
      user avatar
      Marcelo Rivera
      Reference: minds/engine!62