Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 824
    • Issues 824
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 44
    • Merge Requests 44
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !112

Closed
Opened 5 months ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/Ohms] (feat): loading indicator and error message for banners

loading indicator and error message alert for engine#110 (closed)

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/eiennohi/front.git sprint/Ohms.feat.add-loading-indicator-and-show-error-for-banner-uploads
git checkout -b eiennohi/front-sprint/Ohms.feat.add-loading-indicator-and-show-error-for-banner-uploads FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff eiennohi/front-sprint/Ohms.feat.add-loading-indicator-and-show-error-for-banner-uploads

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge eiennohi:sprint/Ohms.feat.add-loading-indicator-and-show-error-for-banner-uploads into master
  • Email patches
  • Plain diff
Pipeline #45307140 passed for 76e08b37 on eiennohi:sprint/Ohms.feat.add-loading-indicator-and-show-error-for-banner-uploads
    Requires 2 more approvals from Devs and Deployers.
    Mark Harding
    Mark Harding
    Brian Hatchet
    Brian Hatchet
    Martin Santangelo
    Martin Santangelo
    Emiliano Balbuena
    Emiliano Balbuena
    Ben Hayward
    Ben Hayward

    Closed by Mark Harding 7 minutes ago

    The changes were not merged into master

    Allows commits from members who can merge to the target branch

    Mentions engine#110 (closed)

    Deletes source branch

    • Discussion 0
    • Commits 2
    • Pipelines 2
    • Changes 9
    • Loading...
    • Marcelo Rivera @eiennohi added 1 commit 5 months ago

      added 1 commit

      • 76e08b37 - (fix): spec tests

      Compare with previous version

    • Mark Harding @markeharding closed 7 minutes ago

      closed

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    0 Assignees
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    6
    6 participants
    user avatar
    Mark Harding
    user avatar
    Brian Hatchet
    user avatar
    Martin Santangelo
    user avatar
    Emiliano Balbuena
    user avatar
    Ben Hayward
    user avatar
    Marcelo Rivera
    Reference: minds/front!112