[Sprint/InterestingIguana](bug): Added in bottom margin for mobile #1416
I want to test this in sandbox on browserstack across a range of devices, so keeping in WIP state for now.
Galaxy 10 / Chrome
IPhone X / Safari
IPhone X / Chrome
IPhone 6 / Safari
Pixel (8.0.0)
Login Page
Request to merge fix/bottom-bar-margin-1416 into master
The source branch is 103 commits behind the target branch
0/3 threads resolved
added 2 commits
changed the description
unmarked as a Work In Progress
added MR::Awaiting Review scoped label
added Squad::Green scoped label
approved this merge request
32 31 33 32 .m-group__chat, .m-group__chat > m-comments__thread { 34 33 height: 100%; 35 height: calc(100vh - 45px); 
OwnerWhy are we removing this?
32 31 33 32 .m-group__chat, .m-group__chat > m-comments__thread { 34 33 height: 100%; 35 height: calc(100vh - 45px); 36 34 position: relative; 37 35 padding: 0; 38 36 margin: 0; 39 37 display: flex; 40 38 flex-direction: column; 41 39 box-sizing: border-box; 42 padding-bottom: 24px; - Owner
why is this going?
- Last updated by Mark Harding
11 11 12 12 &.has-v2-navbar { 13 13 margin-top: 52px; 14 @media screen and (max-width: $max-mobile) { 15 margin: 52px 0 51px 0; - Owner
51?
- Owner
Also, why do we have a bottom margin on mobile topbar?
added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label
- Owner
Lets just remove the bottom bar. Theres so many tasks and hacky changes all because of this.
