Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 175
    • Issues 175
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 38
    • Merge Requests 38
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !277

Merged
Opened 4 days ago by Brian Hatchet@brianhatchet:speech_balloon:
  • Report abuse
Report abuse

(fix) exporting allow comments so its boolean

Ran into a bug with BehaviorSubjects and the allow_comments flag that was getting exported as a '1'

Request to merge feat/disable-comments-526 into master
  • Email patches
  • Plain diff
Pipeline #71805199 passed for 43b06a68 on feat/disable-comments-526
          Merge request approved. Approved by
          Mark Harding
          Mark Harding
          Marcelo Rivera
          Marcelo Rivera
          Martin Santangelo
          Martin Santangelo
          Rami Albatal
          Rami Albatal
          Emiliano Balbuena
          Emiliano Balbuena
          Ben Hayward
          Ben Hayward

          Merged by Mark Harding 50 minutes ago

          The changes were merged into master with 4f056092

          The source branch has been deleted

          Pipeline #72558253 passed for 4f056092 on master
                  • Discussion 0
                  • Commits 1
                  • Pipelines 1
                  • Changes 1
                  • Loading...
                  • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %sprint: Interesting Iguana 4 days ago

                    changed milestone to %sprint: Interesting Iguana

                  • Marcelo Rivera @eiennohi approved this merge request 1 day ago

                    approved this merge request

                  • Mark Harding @markeharding approved this merge request 50 minutes ago

                    approved this merge request

                  • Mark Harding @markeharding merged 50 minutes ago

                    merged

                  • Mark Harding @markeharding mentioned in commit 4f056092 50 minutes ago

                    mentioned in commit 4f056092

                  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                  Please register or sign in to reply
                  Assignee
                  Brian Hatchet's avatar Brian Hatchet @brianhatchet
                  Assign to
                  sprint: Interesting Iguana
                  Milestone
                  sprint: Interesting Iguana
                  Assign milestone
                  None
                  Time tracking
                  No estimate or time spent
                  0
                  Labels
                  None
                  Assign labels
                  • View project labels
                  Lock merge request
                  Unlocked
                  7
                  7 participants
                  user avatar
                  Martin Santangelo
                  user avatar
                  Rami Albatal
                  user avatar
                  Emiliano Balbuena
                  user avatar
                  Ben Hayward
                  user avatar
                  Brian Hatchet
                  user avatar
                  Mark Harding
                  user avatar
                  Marcelo Rivera
                  Reference: minds/engine!277

                  Revert this merge request

                  This will create a new commit in order to revert the existing changes.

                  Switch branch
                  Cancel
                  A new branch will be created in your fork and a new merge request will be started.

                  Cherry-pick this merge request

                  Switch branch
                  Cancel
                  A new branch will be created in your fork and a new merge request will be started.