Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 820
    • Issues 820
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 47
    • Merge Requests 47
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !392

Open
Opened 3 weeks ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/HipsterHedgehog] (feat): image and video cards should open links in new tab in juryduty

closes !377 (closed)

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/open-in-new-tab-in-juryduty origin/feat/open-in-new-tab-in-juryduty

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff feat/open-in-new-tab-in-juryduty

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/open-in-new-tab-in-juryduty into master
The source branch is 157 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #68856055 passed for 36c185bd on feat/open-in-new-tab-in-juryduty
    Requires 2 more approvals from Devs and Deployers.
    Martin Santangelo
    Martin Santangelo
    Mark Harding
    Mark Harding
    Brian Hatchet
    Brian Hatchet
    Ben Hayward
    Ben Hayward
    Emiliano Balbuena
    Emiliano Balbuena
    There are merge conflicts. Resolve these conflicts or ask someone with write access to this repository to merge it locally

    Deletes source branch

    You can merge this merge request manually using the
    • Discussion 1
    • Commits 1
    • Pipelines 1
    • Changes 7
    0/1 thread resolved
    • Loading...
    • Marcelo Rivera @eiennohi mentioned in merge request !377 (closed) 3 weeks ago

      mentioned in merge request !377 (closed)

    • Mark Harding @markeharding added Squad::Yellow scoped label 6 days ago

      added Squad::Yellow scoped label

    • Mark Harding
      Mark Harding @markeharding started a thread on the diff 6 hours ago
      src/app/modules/report/juryduty/session/content.component.html
      15 15 </div>
      16 16
      17 17 <ng-container *ngIf="report.entity; else noEntity">
      18 <minds-card *ngIf="report.entity"
      19 class=""
      20 [object]="report.entity"
      21 hostClass="mdl-card m-border"
      22 ></minds-card>
      18 <minds-card
      19 *ngIf="report.entity"
      20 class=""
      21 [object]="report.entity"
      22 [target]="'_blank'"
      • Mark Harding
        Mark Harding @markeharding · 6 hours ago
        Owner

        does it need to be inside of binding? could you could just do target="_blank"?

      • Please register or sign in to reply
    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    0 Assignees
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    1
    Labels
    Squad::Yellow
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    6
    6 participants
    user avatar
    Martin Santangelo
    user avatar
    Mark Harding
    user avatar
    Brian Hatchet
    user avatar
    Ben Hayward
    user avatar
    Emiliano Balbuena
    user avatar
    Marcelo Rivera
    Reference: minds/front!392