changed milestone to %sprint: Interesting Iguana
changed title from Feat/disable comments 526 to (Feat) disable comments 526
added 4 commits
- b8f503ae...d7f9cc7d - 3 commits from branch
master - e93b4129 - Merge remote-tracking branch 'upstream/master' into feat/disable-comments-526
- b8f503ae...d7f9cc7d - 3 commits from branch
approved this merge request
added MR::Awaiting Review scoped label
added 8 commits
- 032dc9ae...12a0ab82 - 6 commits from branch
master - b3689ba5 - Merge branch 'master' of gitlab.com:minds/front
- 4b51976e - Merge branch 'master' into feat/disable-comments-526
- 032dc9ae...12a0ab82 - 6 commits from branch
added 1 commit
- 95ca222a - Adding 'allow-comments-toggle' feature. Setting featuresservice assumption to false
added 45 commits
- 95ca222a...bda69088 - 44 commits from branch
master - 48216571 - Merge remote-tracking branch 'origin/master' into feat/disable-comments-526
- 95ca222a...bda69088 - 44 commits from branch
added 12 commits
- 48216571...3fad9777 - 11 commits from branch
master - 5c29a195 - Merge remote-tracking branch 'upstream/master' into feat/disable-comments-526
- 48216571...3fad9777 - 11 commits from branch
Resolved by Brian Hatchet- Last updated by Brian Hatchet
87 94 private overlayModal: OverlayModalService, 88 95 private cd: ChangeDetectorRef, 89 96 private timeDiffService: TimeDiffService, 90 private el: ElementRef 97 private el: ElementRef, 98 protected activityService: ActivityService 91 99 ) {} 92 100 93 101 ngOnInit() { 94 102 this.commentAge$ = this.timeDiffService.source.pipe(map(secondsElapsed => { 95 103 return (this.comment.time_created - secondsElapsed * 0.01) * 1000; 96 104 })); 105 this.canReply = this.entity['allow_comments']; - Owner
q. should this be instantiated from the tree/thread level?
DeveloperAdhering to Mark's question here. Remember that, if you don't want to be passing the property through the whole tree, you can also use a shared just-for-state @Injectable() service using
providers: []on the top level component (the comments list container), and injecting it on the constructor() part of the children components.
MaintainerI am confused. I am pretty sure that is exactly what I am doing.
Provided here. https://gitlab.com/minds/front/blob/feat/disable-comments-526/src/app/modules/comments/list/list.component.ts#L28
Then I just inject it into whatever component needs to respond at the constructor level.
changed this line in version 10 of the diff
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
- Last updated by Brian Hatchet
40 43 41 44 scroll_listener; 42 45 43 menuOptions: Array<string> = ['edit', 'follow', 'feature', 'delete', 'report', 'subscribe', 'set-explicit', 'remove-explicit', 'rating']; 46 menuOptions: Array<string> = ['edit', 'follow', 'feature', 47 'delete', 'report', 'subscribe', 48 'set-explicit', 'remove-explicit', 'rating', 49 'allow-comments', 'disable-comments']; - Developer
Check my comment above re: toggles using the same option ID.
changed this line in version 10 of the diff
added 13 commits
- 5c29a195...87b682c6 - 12 commits from branch
master - 7093e8d1 - Merge remote-tracking branch 'origin/master' into feat/disable-comments-526
- 5c29a195...87b682c6 - 12 commits from branch
added Squad::Green scoped label
approved this merge request
added 20 commits
- 3ebd1846...157e56d4 - 17 commits from branch
master - 97042103 - Merge remote-tracking branch 'origin/master' into feat/disable-comments-526
- 4ce3fc42 - Merge remote-tracking branch 'origin/master' into feat/disable-comments-526
- f76b770f - CR changes and BehaviorSubject overhaul
Toggle commit list- 3ebd1846...157e56d4 - 17 commits from branch
approved this merge request
- Owner
Looks good to me. Lets get another approval and we can merge in
approved this merge request
7/9 threads resolved