Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 174
    • Issues 174
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 41
    • Merge Requests 41
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !192

Merged
Opened 1 month ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/GiddyGiraffe] (fix): don't show suggestions if near subscriptions ratelimit threshold

closes #267 (closed)

Request to merge eiennohi:sprint/GiddyGiraffe.fix.dont-suggest-users-over-ratelimit-threshold into master
  • Email patches
  • Plain diff
Pipeline #70739220 failed for ec4f4b04 on eiennohi:sprint/GiddyGiraffe.fix.dont-suggest-users-over-ratelimit-threshold
          Merge request approved. Approved by
          Mark Harding
          Mark Harding
          Martin Santangelo
          Martin Santangelo
          Rami Albatal
          Rami Albatal
          Ben Hayward
          Ben Hayward
          Brian Hatchet
          Brian Hatchet
          Emiliano Balbuena
          Emiliano Balbuena

          Merged by Mark Harding 5 hours ago

          The changes were merged into master with 11bb14cd

          The source branch has been deleted

          Allows commits from members who can merge to the target branch

          Closed #267 (closed)

          Pipeline #72415311 passed for 11bb14cd on master
                  • Discussion 10
                  • Commits 6
                  • Pipelines 8
                  • Changes 7
                  7/7 threads resolved
                  • Loading...
                  • Mark Harding
                    Mark Harding @markeharding · 1 month ago
                    Owner

                    Can this be moved to Manager with spec tests for safety?

                  • Marcelo Rivera @eiennohi added 2 commits 1 month ago

                    added 2 commits

                    • 99204fa7 - (fix): don't show suggestions if near subscriptions ratelimit threshold
                    • 30c527c7 - (feat): spec tests

                    Compare with previous version

                  • Mark Harding
                    Mark Harding @markeharding started a thread on an old version of the diff 1 month ago
                    Resolved by Ben Hayward 1 month ago
                  • Marcelo Rivera @eiennohi added 1 commit 1 month ago

                    added 1 commit

                    • a630a65e - (fix): delegates should be stateless

                    Compare with previous version

                  • Mark Harding
                    Mark Harding @markeharding · 1 month ago
                    Owner

                    @eiennohi don't forget about these.. also failing spec tests

                  • Marcelo Rivera @eiennohi added 1 commit 1 month ago

                    added 1 commit

                    • 6c92280e - (fix): delegates should be stateless

                    Compare with previous version

                  • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 month ago

                    approved this merge request

                  • Emiliano Balbuena
                    Emiliano Balbuena @edgebal started a thread on an old version of the diff 1 month ago
                    Resolved by Marcelo Rivera 1 month ago
                  • Ben Hayward @benhayward.ben resolved all discussions 1 month ago

                    resolved all discussions

                  • Mark Harding @markeharding added MR::Awaiting Review scoped label 3 weeks ago

                    added MR::Awaiting Review scoped label

                  • Mark Harding @markeharding approved this merge request 1 week ago

                    approved this merge request

                  • Mark Harding
                    Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
                    Resolved by Marcelo Rivera 1 week ago
                  • Mark Harding
                    Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
                    Resolved by Marcelo Rivera 1 week ago
                  • Mark Harding
                    Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
                    Resolved by Marcelo Rivera 1 week ago
                  • Mark Harding
                    Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
                    Resolved by Marcelo Rivera 1 week ago
                  • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 week ago

                    added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

                  • Mark Harding
                    Mark Harding @markeharding started a thread on the diff 1 week ago
                    Resolved by Marcelo Rivera 1 week ago
                  • Mark Harding @markeharding unapproved this merge request 1 week ago

                    unapproved this merge request

                  • Marcelo Rivera @eiennohi resolved all threads 1 week ago

                    resolved all threads

                  • Marcelo Rivera @eiennohi added 143 commits 1 week ago

                    added 143 commits

                    • 6c92280e...5e6901e0 - 138 commits from branch minds:master
                    • d85520a8 - Merge remote-tracking branch 'upstream/master' into...
                    • f5b62627 - (fix): use correct mapping
                    • f1fe5785 - (fix): should cache specifically when subscribing
                    • 77064e0d - (fix): spec tests
                    • 7ff36c15 - (fix): don't use null colaescing operator

                    Compare with previous version

                    Toggle commit list
                  • Marcelo Rivera @eiennohi added 1 commit 1 week ago

                    added 1 commit

                    • a9e0452d - (fix): cleanup

                    Compare with previous version

                  • Marcelo Rivera @eiennohi added 1 commit 1 week ago

                    added 1 commit

                    • 4a915434 - (fix): several fixes and cleanup

                    Compare with previous version

                  • Marcelo Rivera @eiennohi added 1 commit 1 week ago

                    added 1 commit

                    • ec4f4b04 - (fix): several fixes and cleanup

                    Compare with previous version

                  • Mark Harding @markeharding added Squad::Yellow scoped label 6 days ago

                    added Squad::Yellow scoped label

                  • Mark Harding @markeharding approved this merge request 5 hours ago

                    approved this merge request

                  • Mark Harding @markeharding merged 5 hours ago

                    merged

                  • Mark Harding @markeharding mentioned in commit 11bb14cd 5 hours ago

                    mentioned in commit 11bb14cd

                  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                  Please register or sign in to reply
                  0 Assignees
                  None
                  Assign to
                  None
                  Milestone
                  None
                  Assign milestone
                  None
                  Time tracking
                  No estimate or time spent
                  2
                  Labels
                  MR::Requires Changes Squad::Yellow
                  Assign labels
                  • View project labels
                  Lock merge request
                  Unlocked
                  7
                  7 participants
                  user avatar
                  Martin Santangelo
                  user avatar
                  Rami Albatal
                  user avatar
                  Ben Hayward
                  user avatar
                  Brian Hatchet
                  user avatar
                  Emiliano Balbuena
                  user avatar
                  Mark Harding
                  user avatar
                  Marcelo Rivera
                  Reference: minds/engine!192

                  Revert this merge request

                  This will create a new commit in order to revert the existing changes.

                  Switch branch
                  Cancel
                  A new branch will be created in your fork and a new merge request will be started.

                  Cherry-pick this merge request

                  Switch branch
                  Cancel
                  A new branch will be created in your fork and a new merge request will be started.