Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 173
    • Issues 173
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 43
    • Merge Requests 43
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !251

Open
Opened 2 weeks ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/InterestingIguana](feat): Offchain boost rate limiting #475

Closes #475

May need to distribute off-chain tokens for staging, using the php-cli. php cli.php rewards issue --username=nemofin --amount=10000

image

Edited 2 weeks ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/rate-limit-boost-475 origin/feat/rate-limit-boost-475

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff feat/rate-limit-boost-475

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/rate-limit-boost-475 into master
The source branch is 62 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #72258346 passed for 9f3bcb40 on feat/rate-limit-boost-475
          Requires 2 more approvals from Devs and Deployers.
          Brian Hatchet
          Brian Hatchet
          Emiliano Balbuena
          Emiliano Balbuena
          Marcelo Rivera
          Marcelo Rivera
          Rami Albatal
          Rami Albatal
          Mark Harding
          Mark Harding
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #475

          Deletes source branch

          • Discussion 9
          • Commits 8
          • Pipelines 8
          • Changes 6
          3/3 threads resolved
          • Loading...
          • Ben Hayward
            Ben Hayward @benhayward.ben · 2 weeks ago
            Developer

            Need to do some testing, and run this by somebody. Not 100% sure I've properly filtered down the transactions as the number coming out is not quite what I'd expect (though is close). Could be related to ES running under low disk constraints.

          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 2 weeks ago
            Resolved by Ben Hayward 2 weeks ago
          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 2 weeks ago
            Resolved by Ben Hayward 2 weeks ago
          • Mark Harding @markeharding added MR::Requires Changes scoped label 2 weeks ago

            added MR::Requires Changes scoped label

          • Ben Hayward @benhayward.ben added 2 commits 2 weeks ago

            added 2 commits

            • 6015b386 - Added in rate limits for offchain boosts.
            • ad1bd20f - Updates, refactor and added tests

            Compare with previous version

          • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

            added 1 commit

            • 21f43ead - Updated, added in reduce for counting impressions and extra test

            Compare with previous version

          • Ben Hayward @benhayward.ben added 2 commits 2 weeks ago

            added 2 commits

            • 1e8d36d4 - spacing
            • 3817cb1f - syntax

            Compare with previous version

          • Ben Hayward @benhayward.ben unmarked as a Work In Progress 2 weeks ago

            unmarked as a Work In Progress

          • Ben Hayward @benhayward.ben changed the description 2 weeks ago

            changed the description

          • Ben Hayward @benhayward.ben resolved all discussions 2 weeks ago

            resolved all discussions

          • Ben Hayward @benhayward.ben resolved all discussions 2 weeks ago

            resolved all discussions

          • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 2 weeks ago

            added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

          • Ben Hayward @benhayward.ben mentioned in issue #591 2 weeks ago

            mentioned in issue #591

          • Ben Hayward @benhayward.ben mentioned in issue #592 2 weeks ago

            mentioned in issue #592

          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 week ago

            approved this merge request

          • Marcelo Rivera @eiennohi approved this merge request 1 week ago

            approved this merge request

          • Ben Hayward
            Ben Hayward @benhayward.ben · 1 week ago
            Developer

            @eiennohi @brianhatchet did you test with tokens? I was trying to get into this with kubectl to issue some to people. (this may have to wait till monday but if you haven't already got some, send me your usernames on staging)

          • Mark Harding @markeharding added Squad::Green scoped label 5 days ago

            added Squad::Green scoped label

          • Ben Hayward
            Ben Hayward @benhayward.ben · 3 days ago
            Developer
            1. boosted for 5000
            2. boosted dif post for 4000
            3. boosted dif post for 2000 - error
            4. boosted for 1000 - success (max of 10k now reached)
            5. boosted for 1000 - error

            image

          • Emiliano Balbuena
            Emiliano Balbuena @edgebal started a thread on an old version of the diff 3 days ago
            Resolved by Ben Hayward 16 hours ago
          • Ben Hayward @benhayward.ben added 1 commit 16 hours ago

            added 1 commit

            • 2f37b154 - added in config for max

            Compare with previous version

          • Ben Hayward @benhayward.ben added 1 commit 16 hours ago

            added 1 commit

            • 6c616c16 - added in config for max

            Compare with previous version

          • Ben Hayward @benhayward.ben resolved all threads 16 hours ago

            resolved all threads

          • Ben Hayward @benhayward.ben added 1 commit 1 hour ago

            added 1 commit

            • 9f3bcb40 - fixed failing tests

            Compare with previous version

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Awaiting Review Squad::Green
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          7
          7 participants
          user avatar
          Brian Hatchet
          user avatar
          Emiliano Balbuena
          user avatar
          Marcelo Rivera
          user avatar
          Rami Albatal
          user avatar
          Mark Harding
          user avatar
          Martin Santangelo
          user avatar
          Ben Hayward
          Reference: minds/engine!251