Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 811
    • Issues 811
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 46
    • Merge Requests 46
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !450

Merged
Opened 6 days ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/InterestingIguana](feat): max video size #1506

Closes #1506 (closed) Depends on engine!269 (merged)

image

Edited 6 days ago by Ben Hayward
Request to merge feat/max-video-size-1506 into master
  • Email patches
  • Plain diff
Pipeline #70787664 passed with warnings for b7e58cbe on feat/max-video-size-1506
          Merge request approved. Approved by
          Mark Harding
          Mark Harding
          Brian Hatchet
          Brian Hatchet
          Marcelo Rivera
          Marcelo Rivera
          Martin Santangelo
          Martin Santangelo
          Emiliano Balbuena
          Emiliano Balbuena

          Merged by Mark Harding 2 hours ago

          The changes were merged into master with 157e56d4

          The source branch has been deleted

          Closed #1506 (closed)

          Pipeline #71871862 passed for 157e56d4 on master
                • Discussion 1
                • Commits 5
                • Pipelines 3
                • Changes 3
                • Loading...
                • Ben Hayward @benhayward.ben mentioned in merge request engine!269 (merged) 6 days ago

                  mentioned in merge request engine!269 (merged)

                • Ben Hayward @benhayward.ben added 2 commits 6 days ago

                  added 2 commits

                  • e792c991 - Updating text with filesize
                  • b7e58cbe - Spacing

                  Compare with previous version

                • Ben Hayward @benhayward.ben changed the description 6 days ago

                  changed the description

                • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label 6 days ago

                  added MR::Awaiting Review scoped label

                • Mark Harding @markeharding added Squad::Green scoped label 2 days ago

                  added Squad::Green scoped label

                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 1 day ago
                  Maintainer

                  Ok, your code is finally testable on staging. And it works perfectly!

                  I configured the staging environment to have a --set max_video_file_size=40000000 and it yells at me quite nicely when I try to upload a 2.5 gig video.

                  There is a minor display issue for unrealistically small file_sizes where the division will get us engineering notation, but that's hardly an issue.

                • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 day ago

                  approved this merge request

                • Mark Harding @markeharding approved this merge request 2 hours ago

                  approved this merge request

                • Mark Harding @markeharding merged 2 hours ago

                  merged

                • Mark Harding @markeharding mentioned in commit 157e56d4 2 hours ago

                  mentioned in commit 157e56d4

                • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                Please register or sign in to reply
                0 Assignees
                None
                Assign to
                None
                Milestone
                None
                Assign milestone
                None
                Time tracking
                No estimate or time spent
                2
                Labels
                MR::Awaiting Review Squad::Green
                Assign labels
                • View project labels
                Lock merge request
                Unlocked
                6
                6 participants
                user avatar
                Marcelo Rivera
                user avatar
                Martin Santangelo
                user avatar
                Emiliano Balbuena
                user avatar
                Mark Harding
                user avatar
                Brian Hatchet
                user avatar
                Ben Hayward
                Reference: minds/front!450

                Revert this merge request

                This will create a new commit in order to revert the existing changes.

                Switch branch
                Cancel
                A new branch will be created in your fork and a new merge request will be started.

                Cherry-pick this merge request

                Switch branch
                Cancel
                A new branch will be created in your fork and a new merge request will be started.