Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 805
    • Issues 805
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 49
    • Merge Requests 49
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !450

Open
Opened 5 days ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/InterestingIguana](feat): max video size #1506

Closes #1506 Depends on engine!269

image

Edited 5 days ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/max-video-size-1506 origin/feat/max-video-size-1506

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff feat/max-video-size-1506

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/max-video-size-1506 into master
The source branch is 66 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #70787664 passed for b7e58cbe on feat/max-video-size-1506
          Requires approval from Deployers. Approved by
          Brian Hatchet
          Brian Hatchet
          Marcelo Rivera
          Marcelo Rivera
          Martin Santangelo
          Martin Santangelo
          Mark Harding
          Mark Harding
          Emiliano Balbuena
          Emiliano Balbuena
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #1506

          Deletes source branch

          • Discussion 1
          • Commits 5
          • Pipelines 3
          • Changes 3
          • Loading...
          • Ben Hayward @benhayward.ben mentioned in merge request engine!269 5 days ago

            mentioned in merge request engine!269

          • Ben Hayward @benhayward.ben added 2 commits 5 days ago

            added 2 commits

            • e792c991 - Updating text with filesize
            • b7e58cbe - Spacing

            Compare with previous version

          • Ben Hayward @benhayward.ben changed the description 5 days ago

            changed the description

          • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label 5 days ago

            added MR::Awaiting Review scoped label

          • Mark Harding @markeharding added Squad::Green scoped label 15 hours ago

            added Squad::Green scoped label

          • Brian Hatchet
            Brian Hatchet :speech_balloon: @brianhatchet · 6 minutes ago
            Maintainer

            Ok, your code is finally testable on staging. And it works perfectly!

            I configured the staging environment to have a --set max_video_file_size=40000000 and it yells at me quite nicely when I try to upload a 2.5 gig video.

            There is a minor display issue for unrealistically small file_sizes where the division will get us engineering notation, but that's hardly an issue.

          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 6 minutes ago

            approved this merge request

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Awaiting Review Squad::Green
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          6
          6 participants
          user avatar
          Marcelo Rivera
          user avatar
          Martin Santangelo
          user avatar
          Mark Harding
          user avatar
          Emiliano Balbuena
          user avatar
          Brian Hatchet
          user avatar
          Ben Hayward
          Reference: minds/front!450