Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 162
    • Issues 162
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 41
    • Merge Requests 41
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !269

Open
Opened 4 days ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/InterestingIguana](bug): Adding in max video filesize config for front/1506

Closes front#1506 Depends on front!450

Edited 4 days ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/max-video-size-1506 origin/feat/max-video-size-1506

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff feat/max-video-size-1506

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/max-video-size-1506 into master
The source branch is 13 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #70784486 passed for bdd634c0 on feat/max-video-size-1506
          Requires 2 more approvals from Devs and Deployers.
          Marcelo Rivera
          Marcelo Rivera
          Martin Santangelo
          Martin Santangelo
          Rami Albatal
          Rami Albatal
          Brian Hatchet
          Brian Hatchet
          Mark Harding
          Mark Harding
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes front#1506

          Deletes source branch

          • Discussion 1
          • Commits 1
          • Pipelines 1
          • Changes 2
          0/1 thread resolved
          • Loading...
          • Ben Hayward @benhayward.ben mentioned in merge request front!450 4 days ago

            mentioned in merge request front!450

          • Ben Hayward @benhayward.ben changed the description 4 days ago

            changed the description

          • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label 4 days ago

            added MR::Awaiting Review scoped label

          • Mark Harding @markeharding added Squad::Green scoped label 4 hours ago

            added Squad::Green scoped label

          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 1 hour ago
            Controllers/api/v1/minds/config.php
            34 34 "max_video_length" => (Core\Session::getLoggedInUser() && Core\Session::getLoggedInUser()->isPlus())
            35 35 ? Minds\Core\Config::_()->get('max_video_length_plus')
            36 36 : Minds\Core\Config::_()->get('max_video_length'),
            37 "max_video_file_size" => Minds\Core\Config::_()->get('max_video_file_size') ?: [],
            • Mark Harding
              Mark Harding @markeharding · 1 hour ago
              Owner

              why is it falling back to an array?

            • Please register or sign in to reply
          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Awaiting Review Squad::Green
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          7
          7 participants
          user avatar
          Marcelo Rivera
          user avatar
          Martin Santangelo
          user avatar
          Rami Albatal
          user avatar
          Brian Hatchet
          user avatar
          Mark Harding
          user avatar
          Emiliano Balbuena
          user avatar
          Ben Hayward
          Reference: minds/engine!269