Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 162
    • Issues 162
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 41
    • Merge Requests 41
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !256

Merged
Opened 1 week ago by Juan Manuel Solaro@juanmsolaro
  • Report abuse
Report abuse

[Sprint/InterestingIguana] (feat) ability to disable toaster notifications

Closes #239 (closed). Depends on front!425 (merged)

Edited 1 week ago by Juan Manuel Solaro
Request to merge feat/ability-to-disable-toaster-239 into master
  • Email patches
  • Plain diff
Pipeline #70577632 passed with warnings for 30edf177 on feat/ability-to-disable-toaster-239
          Merge request approved. Approved by
          Mark Harding
          Mark Harding
          Martin Santangelo
          Martin Santangelo
          Marcelo Rivera
          Marcelo Rivera
          Emiliano Balbuena
          Emiliano Balbuena
          Rami Albatal
          Rami Albatal
          Ben Hayward
          Ben Hayward

          Merged by Mark Harding 24 minutes ago

          The changes were merged into master with 88286ad8

          The source branch has been deleted

          Closed #239 (closed)

          Pipeline #71428625 passed for 88286ad8 on master
                  • Discussion 4
                  • Commits 2
                  • Pipelines 2
                  • Changes 2
                  0/1 thread resolved
                  • Loading...
                  • Juan Manuel Solaro @juanmsolaro mentioned in merge request front!425 (merged) 1 week ago

                    mentioned in merge request front!425 (merged)

                  • Juan Manuel Solaro @juanmsolaro unmarked as a Work In Progress 1 week ago

                    unmarked as a Work In Progress

                  • Juan Manuel Solaro @juanmsolaro changed the description 1 week ago

                    changed the description

                  • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 week ago

                    approved this merge request

                  • Ben Hayward @benhayward.ben approved this merge request 1 week ago

                    approved this merge request

                    • Mark Harding
                      Mark Harding @markeharding · 5 days ago
                      Owner

                      3 approval on this. Did anyone check to see if it works? 500 error on settings endpoint.

                      @juanmsolaro - you are using isToas... but declaring function as getToas

                    • Collapse replies
                    • Juan Manuel Solaro
                      Juan Manuel Solaro @juanmsolaro · 5 days ago
                      Developer

                      My bad. Fixed right now.

                    • Please register or sign in to reply
                  • Juan Manuel Solaro @juanmsolaro added 1 commit 5 days ago

                    added 1 commit

                    • 30edf177 - (fix) replace isToasterNotifi in settings

                    Compare with previous version

                  • Ben Hayward
                    Ben Hayward @benhayward.ben · 5 days ago
                    Developer

                    Hey @juanmsolaro, you got a PHPSpec issue in the pipeline there.

                  • Ben Hayward @benhayward.ben added MR::Requires Changes scoped label 5 days ago

                    added MR::Requires Changes scoped label

                  • Mark Harding @markeharding added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 5 days ago

                    added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

                  • Ben Hayward
                    Ben Hayward @benhayward.ben · 12 hours ago
                    Developer

                    Tried to test this but I can't get them to pop up at all. Sockets are working, notifications aren't triggering properly.

                    Probably something missing from config?

                  • Mark Harding @markeharding added Squad::Yellow scoped label 2 hours ago

                    added Squad::Yellow scoped label

                  • Mark Harding @markeharding approved this merge request 24 minutes ago

                    approved this merge request

                  • Mark Harding @markeharding merged 24 minutes ago

                    merged

                  • Mark Harding @markeharding mentioned in commit 88286ad8 24 minutes ago

                    mentioned in commit 88286ad8

                  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                  Please register or sign in to reply
                  0 Assignees
                  None
                  Assign to
                  None
                  Milestone
                  None
                  Assign milestone
                  None
                  Time tracking
                  No estimate or time spent
                  2
                  Labels
                  MR::Awaiting Review Squad::Yellow
                  Assign labels
                  • View project labels
                  Lock merge request
                  Unlocked
                  8
                  8 participants
                  user avatar
                  Martin Santangelo
                  user avatar
                  Marcelo Rivera
                  user avatar
                  Emiliano Balbuena
                  user avatar
                  Rami Albatal
                  user avatar
                  Ben Hayward
                  user avatar
                  Brian Hatchet
                  user avatar
                  Mark Harding
                  Reference: minds/engine!256

                  Revert this merge request

                  This will create a new commit in order to revert the existing changes.

                  Switch branch
                  Cancel
                  A new branch will be created in your fork and a new merge request will be started.

                  Cherry-pick this merge request

                  Switch branch
                  Cancel
                  A new branch will be created in your fork and a new merge request will be started.