Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 809
    • Issues 809
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 53
    • Merge Requests 53
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Issues
  • #1443

Closed
Open
Opened 3 weeks ago by Ben Hayward@benhayward.ben
  • Report abuse
  • New issue
Report abuse New issue

(bug): NSFW tags on activities not propagating to their entity

Summary

It appears that when a post is made NSFW, the change is not going down the chain to the actual image entity. The effect of this is that when the image entity is loaded for the image endpoints, it does not have any data under nsfw, so shows up anyway.

This is also likely responsible for reports of NSFW in sidebars.

https://www.minds.com/newsfeed/988929333995732992

Steps to reproduce

  1. Make an NSFW image post (check pornography & nudity)
  2. Check it out in your gallery - if you see an unblurred image, therein lies your bug.

Further investigation:

  1. Spin up minds console
  2. Run the below
use Minds\Core;
use Minds\Entities;

$db = new Core\Data\Call('entities_by_time');
$activities = $db->getRow("activity:entitylink:997902097930260493");
var_dump($activities);

$activity = new Entities\Activity($activities[0]);
var_dump($activity);

See the NSFW changes did not propagate to the image entity.

Platform information

Web - cross platform

What is the current bug behavior?

NSFW content is visible.

What is the expected correct behavior?

It should not be.

Relevant logs and/or screenshots

image

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

Please solve the reCAPTCHA

We want to be sure it is you, please confirm you are not a robot.

Edited 1 hour ago by Ben Hayward

Related issues
0

    • Ben Hayward @benhayward.ben added S - Triage (New) S - Triage (Questions) T - Bug scoped labels 3 weeks ago

      added S - Triage (New) S - Triage (Questions) T - Bug scoped labels

    • Ben Hayward
      Ben Hayward @benhayward.ben · 3 weeks ago
      Developer

      Awaiting information from user

    • Ben Hayward @benhayward.ben changed the description 3 weeks ago

      changed the description

    • Ben Hayward @benhayward.ben assigned to @benhayward.ben 1 week ago

      assigned to @benhayward.ben

    • Ben Hayward @benhayward.ben changed milestone to %sprint: Interesting Iguana 1 week ago

      changed milestone to %sprint: Interesting Iguana

    • Ben Hayward @benhayward.ben changed weight to 4 1 week ago

      changed weight to 4

    • Ben Hayward @benhayward.ben added Status::InProgress scoped label 1 week ago

      added Status::InProgress scoped label

    • Ben Hayward
      Ben Hayward @benhayward.ben · 1 week ago
      Developer

      image

      Images should be censored, I'm not able to replicate this locally now. Have any changes been made that could have had an affect on this?

      https://www.minds.com/media/988583306234023936

    • Ben Hayward @benhayward.ben added Status::Follow Up scoped label and automatically removed Status::InProgress label 1 week ago

      added Status::Follow Up scoped label and automatically removed Status::InProgress label

    • Ben Hayward @benhayward.ben added Status::InProgress scoped label and automatically removed Status::Follow Up label 2 hours ago

      added Status::InProgress scoped label and automatically removed Status::Follow Up label

    • Ben Hayward @benhayward.ben changed title from (bug): NSFW content not hidden in media page sidebar to (bug): NSFW tags on activities not propagating to their entity 1 hour ago

      changed title from (bug): NSFW content not hidden in media page sidebar to (bug): NSFW tags on activities not propagating to their entity

    • Ben Hayward @benhayward.ben changed the description 1 hour ago

      changed the description

    • Ben Hayward
      Ben Hayward @benhayward.ben · 1 hour ago
      Developer

      Needs another look following the resolution of engine#616

      Changes are not propagating through to the entity from the activity.

    • Ben Hayward @benhayward.ben changed milestone to %sprint: Jolly Jellyfish 1 hour ago

      changed milestone to %sprint: Jolly Jellyfish

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    Ben Hayward's avatar Ben Hayward @benhayward.ben
    Assign to
    None
    Epic
    None
    sprint: Jolly Jellyfish
    Milestone
    sprint: Jolly Jellyfish
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    None
    Due date
    None
    3
    Labels
    Triage::New Triage::Questions Type::Bug
    Assign labels
    • View project labels
    4
    Weight
    4
    Confidentiality
    Not confidential
    Lock issue
    Unlocked
    1
    1 participant
    user avatar
    Ben Hayward
    Reference: minds/front#1443