(bug): NSFW tags on activities not propagating to their entity
Summary
It appears that when a post is made NSFW, the change is not going down the chain to the actual image entity. The effect of this is that when the image entity is loaded for the image endpoints, it does not have any data under nsfw, so shows up anyway.
This is also likely responsible for reports of NSFW in sidebars.
https://www.minds.com/newsfeed/988929333995732992
Steps to reproduce
- Make an NSFW image post (check pornography & nudity)
- Check it out in your gallery - if you see an unblurred image, therein lies your bug.
Further investigation:
- Spin up minds console
- Run the below
use Minds\Core;
use Minds\Entities;
$db = new Core\Data\Call('entities_by_time');
$activities = $db->getRow("activity:entitylink:997902097930260493");
var_dump($activities);
$activity = new Entities\Activity($activities[0]);
var_dump($activity);
See the NSFW changes did not propagate to the image entity.
Platform information
Web - cross platform
What is the current bug behavior?
NSFW content is visible.
What is the expected correct behavior?
It should not be.
Relevant logs and/or screenshots
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)
added S - Triage (New) S - Triage (Questions) T - Bug scoped labels
- Developer
Awaiting information from user
changed the description
assigned to @benhayward.ben
changed milestone to %sprint: Interesting Iguana
changed weight to 4
added Status::InProgress scoped label
- Developer
Images should be censored, I'm not able to replicate this locally now. Have any changes been made that could have had an affect on this?
added Status::Follow Up scoped label and automatically removed Status::InProgress label
added Status::InProgress scoped label and automatically removed Status::Follow Up label
changed title from (bug): NSFW content not hidden in media page sidebar to (bug): NSFW tags on activities not propagating to their entity
changed the description
- Developer
Needs another look following the resolution of engine#616
Changes are not propagating through to the entity from the activity.
changed milestone to %sprint: Jolly Jellyfish