Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 808
    • Issues 808
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 53
    • Merge Requests 53
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !452

Merged
Opened 1 day ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

Nick's update to burger menu layouut

Closes #1331 (closed)

image

Edited 1 day ago by Ben Hayward
Request to merge fix/hamburger-menu-update-1331 into master
  • Email patches
  • Plain diff
Pipeline #71084034 passed for c8b45901 on fix/hamburger-menu-update-1331
          Merge request approved. Approved by
          Brian Hatchet
          Brian Hatchet
          Mark Harding
          Mark Harding
          Marcelo Rivera
          Marcelo Rivera
          Martin Santangelo
          Martin Santangelo
          Emiliano Balbuena
          Emiliano Balbuena

          Merged by Mark Harding 8 hours ago

          The changes were merged into master with 6d54b4a5

          The source branch has been deleted

          Closed #1331 (closed)

          Pipeline #71191256 passed for 6d54b4a5 on master
                • Discussion 3
                • Commits 1
                • Pipelines 1
                • Changes 1
                • Loading...
                • Ben Hayward
                  Ben Hayward @benhayward.ben · 1 day ago
                  Developer

                  Pushing up on Nicks behalf as I believe he has lost access to the original file.

                • Ben Hayward @benhayward.ben changed the description 1 day ago

                  changed the description

                • Mark Harding @markeharding approved this merge request 21 hours ago

                  approved this merge request

                • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 15 hours ago

                  approved this merge request

                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 15 hours ago
                  Maintainer

                  Tested and approved. Looks great, @javanick

                • Mark Harding @markeharding merged 8 hours ago

                  merged

                • Mark Harding @markeharding mentioned in commit 6d54b4a5 8 hours ago

                  mentioned in commit 6d54b4a5

                • Mark Edworthy
                  Mark Edworthy @medworthy · 4 hours ago

                  Yep, looks good @javanick. Glad that we didn't have to stretch too far from my initial modified design (looking at the final design, I agree that having the settings option at the bottom of the menu does make sense and is more "standardised". Also glad to see the inclusion of my recommendation in relation to the Store and Mobile App options).

                  One of the next tasks that would make sense is the inclusion of the "ToS" left side bar menu as suggested within #1460

                  Edited by Mark Edworthy 4 hours ago
                • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                Please register or sign in to reply
                0 Assignees
                None
                Assign to
                None
                Milestone
                None
                Assign milestone
                None
                Time tracking
                No estimate or time spent
                0
                Labels
                None
                Assign labels
                • View project labels
                Lock merge request
                Unlocked
                9
                9 participants
                user avatar
                Marcelo Rivera
                user avatar
                Martin Santangelo
                user avatar
                Emiliano Balbuena
                user avatar
                Mark Edworthy
                user avatar
                Mark Harding
                user avatar
                Brian Hatchet
                user avatar
                Ben Hayward
                Reference: minds/front!452

                Revert this merge request

                This will create a new commit in order to revert the existing changes.

                Switch branch
                Cancel
                A new branch will be created in your fork and a new merge request will be started.

                Cherry-pick this merge request

                Switch branch
                Cancel
                A new branch will be created in your fork and a new merge request will be started.