Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 168
    • Issues 168
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 45
    • Merge Requests 45
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !255

Merged
Opened 1 week ago by Brian Hatchet@brianhatchet:speech_balloon:
  • Report abuse
Report abuse

(feat) Disabling comments 526

Backend for turning off comments Extended the base entities to track whether or not comments are allowed Setup a Permissions/Manager to centralize applying of permissions (much more to come, this is just setting up the flow with comments feature) Setup a new permissions end point that validates and applies the permissions Extended the comments endpoint to enforce comments permissions

Edited 17 hours ago by Brian Hatchet
Request to merge feat/disable-comments-526 into master
  • Email patches
  • Plain diff
Pipeline #71138578 passed for 1f673623 on feat/disable-comments-526
          Merge request approved. Approved by
          Mark Harding
          Mark Harding
          Emiliano Balbuena
          Emiliano Balbuena
          Ben Hayward
          Ben Hayward
          Martin Santangelo
          Martin Santangelo
          Marcelo Rivera
          Marcelo Rivera
          Rami Albatal
          Rami Albatal

          Merged by Mark Harding 2 hours ago

          The changes were merged into master with e33eedaf

          The source branch has been deleted

          Pipeline #71192406 passed for e33eedaf on master
                  • Discussion 2
                  • Commits 6
                  • Pipelines 6
                  • Changes 17
                  0/1 thread resolved
                  • Loading...
                  • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %sprint: Interesting Iguana 1 week ago

                    changed milestone to %sprint: Interesting Iguana

                  • Brian Hatchet :speech_balloon: @brianhatchet added 3 commits 1 week ago

                    added 3 commits

                    • 886b1109...9b79f9ef - 2 commits from branch master
                    • 86295f53 - Merge remote-tracking branch 'upstream/master' into feat/disable-comments-526

                    Compare with previous version

                  • Ben Hayward @benhayward.ben approved this merge request 6 days ago

                    approved this merge request

                  • Mark Harding @markeharding added MR::Awaiting Review label 6 days ago

                    added MR::Awaiting Review label

                  • Brian Hatchet :speech_balloon: @brianhatchet added 6 commits 5 days ago

                    added 6 commits

                    • 86295f53...5797d6ea - 5 commits from branch master
                    • 986fa5d6 - Merge branch 'master' into feat/disable-comments-526

                    Compare with previous version

                  • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 5 days ago

                    added 1 commit

                    • 00de930b - disabling allow-comment-toggle feature by default

                    Compare with previous version

                  • Mark Harding @markeharding approved this merge request 4 days ago

                    approved this merge request

                    • Ben Hayward
                      Ben Hayward @benhayward.ben · 4 days ago
                      Developer

                      Hey Brian, merge conflicts if you hadn't spotted them

                    • Collapse replies
                    • Brian Hatchet
                      Brian Hatchet :speech_balloon: @brianhatchet · 12 hours ago
                      Maintainer

                      Resolved

                    • Please register or sign in to reply
                  • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 17 hours ago

                    added 1 commit

                    • bbf37414 - extending feature flag false by default to the engine

                    Compare with previous version

                  • Brian Hatchet :speech_balloon: @brianhatchet changed title from (feat) disabling comments to (feat) Disabling comments 526 17 hours ago

                    changed title from (feat) disabling comments to (feat) Disabling comments 526

                  • Brian Hatchet :speech_balloon: @brianhatchet changed the description 17 hours ago

                    changed the description

                  • Mark Harding @markeharding approved this merge request 16 hours ago

                    approved this merge request

                  • Ben Hayward @benhayward.ben approved this merge request 15 hours ago

                    approved this merge request

                  • Brian Hatchet :speech_balloon: @brianhatchet added 28 commits 12 hours ago

                    added 28 commits

                    • bbf37414...9a774666 - 27 commits from branch master
                    • 1f673623 - Merge remote-tracking branch 'upstream/master' into feat/disable-comments-526

                    Compare with previous version

                  • Emiliano Balbuena @edgebal approved this merge request 10 hours ago

                    approved this merge request

                  • Mark Harding @markeharding approved this merge request 2 hours ago

                    approved this merge request

                  • Mark Harding @markeharding merged 2 hours ago

                    merged

                  • Mark Harding @markeharding mentioned in commit e33eedaf 2 hours ago

                    mentioned in commit e33eedaf

                  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                  Please register or sign in to reply
                  Assignee
                  Brian Hatchet's avatar Brian Hatchet @brianhatchet
                  Assign to
                  sprint: Interesting Iguana
                  Milestone
                  sprint: Interesting Iguana
                  Assign milestone
                  None
                  Time tracking
                  No estimate or time spent
                  1
                  Labels
                  MR::Awaiting Review
                  Assign labels
                  • View project labels
                  Lock merge request
                  Unlocked
                  7
                  7 participants
                  user avatar
                  Ben Hayward
                  user avatar
                  Martin Santangelo
                  user avatar
                  Marcelo Rivera
                  user avatar
                  Rami Albatal
                  user avatar
                  Brian Hatchet
                  user avatar
                  Mark Harding
                  user avatar
                  Emiliano Balbuena
                  Reference: minds/engine!255

                  Revert this merge request

                  This will create a new commit in order to revert the existing changes.

                  Switch branch
                  Cancel
                  A new branch will be created in your fork and a new merge request will be started.

                  Cherry-pick this merge request

                  Switch branch
                  Cancel
                  A new branch will be created in your fork and a new merge request will be started.