Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 808
    • Issues 808
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 52
    • Merge Requests 52
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !390

Open
Opened 2 weeks ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/HipsterHedgehog] (feat): enable autocomplete for @ tagging

closes #339

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/user-autocomplete origin/feat/user-autocomplete

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff feat/user-autocomplete

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/user-autocomplete into master
The source branch is 52 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #71060962 failed for 1696aa6c on feat/user-autocomplete
          Requires 2 more approvals from Devs and Deployers.
          Mark Harding
          Mark Harding
          Emiliano Balbuena
          Emiliano Balbuena
          Brian Hatchet
          Brian Hatchet
          Ben Hayward
          Ben Hayward
          Martin Santangelo
          Martin Santangelo
          There are merge conflicts. Resolve these conflicts or ask someone with write access to this repository to merge it locally

          Closes #339

          Deletes source branch

          You can merge this merge request manually using the
          • Discussion 7
          • Commits 9
          • Pipelines 4
          • Changes 24
          0/3 threads resolved
          • Loading...
          • Marcelo Rivera @eiennohi mentioned in merge request !380 (closed) 2 weeks ago

            mentioned in merge request !380 (closed)

          • Marcelo Rivera @eiennohi added 9 commits 2 weeks ago

            added 9 commits

            • a967d932...9adda44a - 8 commits from branch master
            • 212bb61b - Merge remote-tracking branch 'upstream/master' into feat/user-autocomplete

            Compare with previous version

          • Mark Harding
            Mark Harding @markeharding · 1 week ago
            Owner
            • Request fired unnecessarily. Screen_Shot_2019-07-02_at_12.11.56_PM

            • Avatars with username

          • Mark Harding @markeharding added MR::Requires Changes label 1 week ago

            added MR::Requires Changes label

          • Marcelo Rivera @eiennohi added 72 commits 6 days ago

            added 72 commits

            • 212bb61b...102ce847 - 67 commits from branch master
            • 3bcbbb69 - Merge remote-tracking branch 'upstream/master' into feat/user-autocomplete
            • 2a873b86 - (feat): reformat text input autocomplete
            • cf89c65d - (fix): use site paddings for suggestion elements
            • 9d8e4ea2 - (feat): enable custom item templates for suggestions
            • 81414daa - (feat): use new custom template for user and hashtags suggestions

            Compare with previous version

            Toggle commit list
          • Marcelo Rivera
            Marcelo Rivera @eiennohi · 6 days ago
            Developer

            @markeharding done. I added the ability to provide a custom template (check out the diffs from the latest commits)

          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 5 days ago
            Last updated by Marcelo Rivera 4 days ago
            src/app/modules/newsfeed/poster/poster.component.html
            1 1 <div class="mdl-card m-border post m-poster" *ngIf="session.isLoggedIn()">
            2 2 <div class="mdl-card__supporting-text">
            3 3 <form (submit)="post()">
            4 <mwl-text-input-autocomplete-container>
            4 <ng-template #itemTemplate let-choice="choice" let-selectChoice="selectChoice">
            • Mark Harding
              Mark Harding @markeharding · 5 days ago
              Owner

              Should these templates not be in another component? What about when we are using comments etc?

            • Marcelo Rivera
              Marcelo Rivera @eiennohi · 4 days ago
              Developer

              I moved to another component for reusability. :slight_smile: About also adding this for the comments poster, there's an issue: this directive only works with inputs and textareas, not content editable divs. Are you ok with me changing the current minds-textarea to a normal textarea?

            • Please register or sign in to reply
          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 3 days ago
            Last updated by Marcelo Rivera 19 hours ago
            src/app/common/components/autocomplete/text-input-autocomplete-menu.component.ts
            1 import { Component, ElementRef, HostListener, OnInit, ViewChild } from '@angular/core';
            2 import { Subject } from 'rxjs';
            3
            4 @Component({
            5 selector: 'm-text-input--autocomplete-menu',
            6 template: `
            • Mark Harding
              Mark Harding @markeharding · 3 days ago
              Owner

              please move to an html file

            • Marcelo Rivera @eiennohi changed this line in version 4 of the diff 19 hours ago

              changed this line in version 4 of the diff

            • Please register or sign in to reply
          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 3 days ago
            Last updated by Marcelo Rivera 19 hours ago
            src/app/modules/newsfeed/poster/poster.component.ts
            260 260 }
            261 261
            262 262 @autobind()
            263 async findTrendingHashtags(searchText: string) {
            264 const response: any = await this.client.get('api/v2/search/suggest/tags', { q: searchText });
            265 return response.tags
            266 .filter(item => item.toLowerCase().includes(searchText.toLowerCase()))
            267 .slice(0, 5);
            263 async findSuggestions(searchText: string, triggerCharacter: string) {
            • Mark Harding
              Mark Harding @markeharding · 3 days ago
              Owner

              This is the job of the autocomplete directive/component. not the poster.

            • Marcelo Rivera @eiennohi changed this line in version 4 of the diff 19 hours ago

              changed this line in version 4 of the diff

            • Please register or sign in to reply
          • Marcelo Rivera @eiennohi added 7 commits 19 hours ago

            added 7 commits

            • 81414daa...5d757256 - 5 commits from branch master
            • c4aff03d - Merge remote-tracking branch 'upstream/master' into feat/user-autocomplete
            • 1696aa6c - (feat): add support for minds-textarea

            Compare with previous version

          • Mark Harding
            Mark Harding @markeharding · 1 hour ago
            Owner

            We have a bunch of failing tests here

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          1
          Labels
          MR::Requires Changes
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          6
          6 participants
          user avatar
          Mark Harding
          user avatar
          Emiliano Balbuena
          user avatar
          Brian Hatchet
          user avatar
          Ben Hayward
          user avatar
          Martin Santangelo
          user avatar
          Marcelo Rivera
          Reference: minds/front!390