Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 168
    • Issues 168
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 46
    • Merge Requests 46
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !232

Open
Opened 2 weeks ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/HiperHedgehog](bug): Fixed forgot password validation

-subdomain=revolutionaryape

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b forgot-password-validation-fix-560 origin/forgot-password-validation-fix-560

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff forgot-password-validation-fix-560

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge forgot-password-validation-fix-560 into master
The source branch is 62 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #68587184 passed for a3364097 on forgot-password-validation-fix-560
          Requires approval from Devs. Approved by
          Marcelo Rivera
          Marcelo Rivera
          Emiliano Balbuena
          Emiliano Balbuena
          Mark Harding
          Mark Harding
          Rami Albatal
          Rami Albatal
          Martin Santangelo
          Martin Santangelo
          Brian Hatchet
          Brian Hatchet
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Deletes source branch

          • Discussion 1
          • Commits 1
          • Pipelines 1
          • Changes 1
          0/1 thread resolved
          • Loading...
          • Mark Harding @markeharding added MR::Awaiting Review label 2 weeks ago

            added MR::Awaiting Review label

          • Marcelo Rivera @eiennohi approved this merge request 1 week ago

            approved this merge request

          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 34 minutes ago
            Controllers/api/v1/forgotpassword.php
            94 94 break;
            95 95 }
            96 96
            97 if (!preg_match('/[A-Z]/', $password) || !preg_match('/\d/', $password) || !preg_match('/[^a-zA-Z\d]/', $password) || preg_match("/\\s/", $password)) {
            • Mark Harding
              Mark Harding @markeharding · 34 minutes ago
              Owner

              should be note use validate_password function? This diverges from what register_user is using, and I think we'll trip up when we come to refactor that.

            • Please register or sign in to reply
          • Mark Harding @markeharding added MR::Requires Changes label and removed MR::Awaiting Review label 34 minutes ago

            added MR::Requires Changes label and removed MR::Awaiting Review label

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          1
          Labels
          MR::Requires Changes
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          7
          7 participants
          user avatar
          Emiliano Balbuena
          user avatar
          Mark Harding
          user avatar
          Rami Albatal
          user avatar
          Martin Santangelo
          user avatar
          Brian Hatchet
          user avatar
          Marcelo Rivera
          user avatar
          Ben Hayward
          Reference: minds/engine!232