[Sprint/InterestingIguana] (feat) ability to disable toaster notifications
Closes engine#239. Depends on engine!256. Also Closes #1450
Request to merge feat/ability-to-disable-toaster-239 into master
The source branch is 70 commits behind the target branch
0/2 threads resolved
added 1 commit
- 3c4b4d9f - (feat) support tags pipe on media page titles
unmarked as a Work In Progress
changed the description
mentioned in merge request engine!256
approved this merge request
approved this merge request
changed the description
Last updated by Juan Manuel Solaro98 98 </div> 99 99 <!-- END: MATURE CONTENT --> 100 100 101 <!-- START: TOASTER NOTIFICATIONS --> 102 <div class="m-settings--section m-border m-settings--toaster"> 103 <h4 i18n="@@MINDS__SETTINGS__TOASTER_TITLE">Notifications</h4> 104 <div class="mdl-card__supporting-text"> 105 <input type="checkbox" 106 id="flag_toaster" 107 (click)="change()" 108 name="toaster_notifications" 109 [(ngModel)]="toaster_notifications" 110 /> 111 <label for="flag_toaster"> 112 <ng-container i18n="@@MINDS__SETTINGS__TOASTER_LABEL">Enable or disable toaster notifications</ng-container> - Owner
Can we rename to 'Enable toaster notifications'?
DeveloperTotally
changed this line in version 4 of the diff
- Owner
The checkbox is always checked despite clicking on it and saving.
- Developer
looking at this now
added MR::Requires Changes label
added 1 commit
- e830d8ef - (fix) change checkbox label and corrected state
added MR::Awaiting Review label and removed MR::Requires Changes label
DeveloperWent to do my duty and test some MRs, but found I can no longer approve.
Setting toggles and persists.
Edited by Guy Thouret
