(bug): Hide login popup on login screen
Summary
The login modal still pops up on the login page, and makes for quite bad UX.
Steps to reproduce
- Go to https://www.minds.com/login on mobile
- Scroll and wait
Platform information
Mobile web cross-platform.
What is the current bug behavior?
The modal pops up when it is redundant.
What is the expected correct behavior?
The modal should not show up on this page.
Relevant logs and/or screenshots
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)
added 2 - Normal P - Platform T - Bug labels
changed the description
changed weight to 1
changed milestone to %sprint: Interesting Iguana
assigned to @gthouret
added Status::InProgress label
- Developer
@benhayward.ben I'm unable to reproduce in Chrome Mobile on two separate Android devices.
added Status::Follow Up label and removed Status::InProgress label
- Owner
did you try scrolling down at all?
- Developer
Weird @gthouret, it's not happening with Chromium for me, but it did pop up the first time I tried in Firefox, then it took a good five minutes of trying refreshing, scrolling and emptying local storage etc, and it popped up again.
(a dark themer is causing the visual issues there
It should trigger on the scroll, but possibly isn't firing correctly. @ottman what Browser are you using?
Edited by Ben Hayward - Developer
I scrolled up, down all over and left them for a while. Do we want rid of the modal completely? I can just track it down in the code base and eliminate.
- Developer
Correct behavior, it should popup if you aren't logged in, and scroll down a page on the site (like a channel or the home page). The issue was originally that it still pops up on the login page, which is redundant.
- Developer
- New Incognito window (no history, no session)
- Go to URL https://www.minds.com/wallet
- This redirects to login page (URL changes to www.minds.com/login)
- Scroll Down
It was triggered from Firefox because if you make Firefox window small bottom bar icons become visible, one of icons is wallet. Clicking that drops you onto the login page with the right conditions to trigger the modal.
Pretty chuffed at finding that