Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 809
    • Issues 809
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 54
    • Merge Requests 54
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Issues
  • #1451

Closed
Open
Opened 2 weeks ago by Ben Hayward@benhayward.ben
  • Report abuse
  • New issue
Report abuse New issue

(bug): Hide login popup on login screen

Summary

The login modal still pops up on the login page, and makes for quite bad UX.

Steps to reproduce

  1. Go to https://www.minds.com/login on mobile
  2. Scroll and wait

Platform information

Mobile web cross-platform.

What is the current bug behavior?

The modal pops up when it is redundant.

What is the expected correct behavior?

The modal should not show up on this page.

Relevant logs and/or screenshots

Wire_2019-06-26_at_6_51_PM

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

Please solve the reCAPTCHA

We want to be sure it is you, please confirm you are not a robot.

Edited 2 weeks ago by Ben Hayward

Related issues
0

    • Ben Hayward @benhayward.ben added 2 - Normal P - Platform T - Bug labels 2 weeks ago

      added 2 - Normal P - Platform T - Bug labels

    • Ben Hayward @benhayward.ben changed the description 2 weeks ago

      changed the description

    • Mark Harding @markeharding changed weight to 1 5 days ago

      changed weight to 1

    • Mark Harding @markeharding changed milestone to %sprint: Interesting Iguana 5 days ago

      changed milestone to %sprint: Interesting Iguana

    • Mark Harding @markeharding assigned to @gthouret 5 days ago

      assigned to @gthouret

    • Guy Thouret @gthouret added Status::InProgress label 4 days ago

      added Status::InProgress label

    • Guy Thouret
      Guy Thouret @gthouret · 4 days ago
      Developer

      @benhayward.ben I'm unable to reproduce in Chrome Mobile on two separate Android devices.

    • Guy Thouret @gthouret added Status::Follow Up label and removed Status::InProgress label 4 days ago

      added Status::Follow Up label and removed Status::InProgress label

    • Bill Ottman
      Bill Ottman :dragon_face: @ottman · 3 days ago
      Owner

      did you try scrolling down at all?

    • Ben Hayward
      Ben Hayward @benhayward.ben · 3 days ago
      Developer

      Weird @gthouret, it's not happening with Chromium for me, but it did pop up the first time I tried in Firefox, then it took a good five minutes of trying refreshing, scrolling and emptying local storage etc, and it popped up again.

      image (a dark themer is causing the visual issues there

      It should trigger on the scroll, but possibly isn't firing correctly. @ottman what Browser are you using?

      Edited by Ben Hayward 3 days ago
    • Guy Thouret
      Guy Thouret @gthouret · 3 days ago
      Developer

      I scrolled up, down all over and left them for a while. Do we want rid of the modal completely? I can just track it down in the code base and eliminate.

    • Guy Thouret
      Guy Thouret @gthouret · 2 days ago
      Developer

      Correct behavior, it should popup if you aren't logged in, and scroll down a page on the site (like a channel or the home page). The issue was originally that it still pops up on the login page, which is redundant.

    • Guy Thouret
      Guy Thouret @gthouret · 18 hours ago
      Developer
      1. New Incognito window (no history, no session)
      2. Go to URL https://www.minds.com/wallet
      3. This redirects to login page (URL changes to www.minds.com/login)
      4. Scroll Down

      It was triggered from Firefox because if you make Firefox window small bottom bar icons become visible, one of icons is wallet. Clicking that drops you onto the login page with the right conditions to trigger the modal.

      Pretty chuffed at finding that :blush:

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    Guy Thouret's avatar Guy Thouret @gthouret
    Assign to
    None
    Epic
    None
    sprint: Interesting Iguana
    Milestone
    sprint: Interesting Iguana
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    None
    Due date
    None
    4
    Labels
    Priority::2 - Normal Product::Platform Status::Follow Up Type::Bug
    Assign labels
    • View project labels
    1
    Weight
    1
    Confidentiality
    Not confidential
    Lock issue
    Unlocked
    4
    4 participants
    user avatar
    Guy Thouret
    user avatar
    Ben Hayward
    user avatar
    Bill Ottman
    user avatar
    Mark Harding
    Reference: minds/front#1451