WIP: [Sprint/InterestingIguana](bug): Pause video when scrolled offscreen #1418
Closes #1418
Need to test this in staging.
Request to merge feat/offscreen-pause-video-1418 into master
The source branch is 31 commits behind the target branch
3/4 threads resolved
added MR::Requires Changes label
Resolved by Ben Hayward- Resolved by Ben Hayward
- Last updated by Ben Hayward
28 28 @ViewChild('progressBar', { static: false }) progressBar: MindsVideoProgressBar; 29 29 @ViewChild('volumeSlider', { static: false }) volumeSlider: MindsVideoVolumeSlider; 30 30 @ViewChild('player', { static: false }) playerRef: MindsPlayerInterface; 31 @ViewChild('playButton', { static: false }) playButton: ElementRef; 32 33 @HostListener('window:scroll') 34 checkScroll() { 35 if (!this.isInView(this.playButton.nativeElement) && this.playerRef.isPlaying()) { - Owner
Should we not just call pause in all scenarios?
DeveloperNot sure what you mean, can you elaborate?
changed this line in version 2 of the diff
- Resolved by Ben Hayward
- Developer
Need to get the AWS configs into the sandbox when I manage to fix up k8s, unless somebody else wants to take a whack for me.