Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 807
    • Issues 807
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 54
    • Merge Requests 54
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !438

Closed
Opened 3 days ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

WIP: [Sprint/InterestingIguana](bug): Throwing exception when max filesize reached

closes #1506 image

Edited 1 day ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/filesize-limit-1506 origin/fix/filesize-limit-1506

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix/filesize-limit-1506

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/filesize-limit-1506 into master
  • Email patches
  • Plain diff
Pipeline #70309414 passed with warnings for e4f0f6e0 on fix/filesize-limit-1506
          Requires approval from Deployers. Approved by
          Marcelo Rivera
          Marcelo Rivera
          Brian Hatchet
          Brian Hatchet
          Emiliano Balbuena
          Emiliano Balbuena
          Martin Santangelo
          Martin Santangelo
          Mark Harding
          Mark Harding

          Closed by Ben Hayward 45 minutes ago

          The changes were not merged into master

          Did not close #1506

          Deletes source branch

          • Discussion 8
          • Commits 4
          • Pipelines 7
          • Changes 1
          2/2 threads resolved
          • Loading...
          • Ben Hayward @benhayward.ben changed the description 3 days ago

            changed the description

          • Ben Hayward @benhayward.ben added 1 commit 3 days ago

            added 1 commit

            • 76adb084 - Update activity.ts

            Compare with previous version

          • Mark Harding
            Mark Harding @markeharding · 3 days ago
            Owner

            I think the check should be done here https://gitlab.com/minds/front/blob/master/src/app/services/attachment.ts#L404

          • Mark Harding
            Mark Harding @markeharding · 3 days ago
            Owner

            See how we are getting the length of the video

          • Ben Hayward @benhayward.ben added 1 commit 3 days ago

            added 1 commit

            • d3e6e10d - Checking filesize of attached video

            Compare with previous version

          • Ben Hayward
            Ben Hayward @benhayward.ben · 3 days ago
            Developer

            @markeharding Simple as like this or does it need to be in a promise?

          • Ben Hayward
            Ben Hayward @benhayward.ben · 2 days ago
            Developer

            image

            max-video-length may need setting in the settings.php unless this is a bug not appearing on my local.

          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 2 days ago
            Resolved by Ben Hayward 2 days ago
          • Mark Harding @markeharding added MR::Requires Changes label 2 days ago

            added MR::Requires Changes label

          • Ben Hayward @benhayward.ben resolved all threads 2 days ago

            resolved all threads

          • Ben Hayward @benhayward.ben added 1 commit 2 days ago

            added 1 commit

            • b5ddcafb - Update attachment.ts

            Compare with previous version

          • Ben Hayward @benhayward.ben added MR::Awaiting Review label and removed MR::Requires Changes label 2 days ago

            added MR::Awaiting Review label and removed MR::Requires Changes label

          • Ben Hayward @benhayward.ben added 1 commit 2 days ago

            added 1 commit

            • 4fd6793c - Update attachment.ts

            Compare with previous version

          • Ben Hayward
            Ben Hayward @benhayward.ben · 2 days ago
            Developer

            Updated to match new limit of 4GB

          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 2 days ago
            Resolved by Ben Hayward 2 days ago
          • Ben Hayward @benhayward.ben added 1 commit 2 days ago

            added 1 commit

            • e4f0f6e0 - Update attachment.ts

            Compare with previous version

          • Ben Hayward @benhayward.ben resolved all threads 2 days ago

            resolved all threads

          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 2 days ago

            approved this merge request

          • Ben Hayward @benhayward.ben removed MR::Awaiting Review label 2 days ago

            removed MR::Awaiting Review label

          • Ben Hayward @benhayward.ben added MR::Awaiting Review label 2 days ago

            added MR::Awaiting Review label

          • Marcelo Rivera @eiennohi approved this merge request 1 day ago

            approved this merge request

          • Ben Hayward @benhayward.ben marked as a Work In Progress 1 day ago

            marked as a Work In Progress

          • Ben Hayward
            Ben Hayward @benhayward.ben · 1 day ago
            Developer

            Need to get this filesize value from config, need to follow the source of video length.

            Edited by Ben Hayward 1 day ago
          • Mark Harding @markeharding added MR::Requires Changes label and removed MR::Awaiting Review label 1 day ago

            added MR::Requires Changes label and removed MR::Awaiting Review label

          • Ben Hayward @benhayward.ben closed 45 minutes ago

            closed

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          1
          Labels
          MR::Requires Changes
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          6
          6 participants
          user avatar
          Emiliano Balbuena
          user avatar
          Martin Santangelo
          user avatar
          Mark Harding
          user avatar
          Ben Hayward
          user avatar
          Marcelo Rivera
          user avatar
          Brian Hatchet
          Reference: minds/front!438