Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 152
    • Issues 152
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 46
    • Merge Requests 46
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Issues
  • #616

Closed
Open
Opened 17 minutes ago by Brian Hatchet@brianhatchet:speech_balloon:
  • Report abuse
  • New issue
Report abuse New issue

(chore) refactor activity links into a Propagate action

We're doing a lot of this.

https://gitlab.com/minds/engine/blob/master/Core/Feeds/Firehose/Manager.php#L106

foreach ($this->db->getRow('activity:entitylink:'.$entity->getGUID()) as $parentGuid => $ts) {

Because blogs contain links to activities when they get published. Images and videos contain multiple links to activities (one image to many activities). Yet, we have properties like NSFW, NSFW_LOCK, allow_comments ... etc that need to be propagated up and down the chain

So, when an owner or admin changes a property that applies to parents or their children, we need to create an action that applies those changes up and down the chain.

There's a question of source of truth. If there is a collision between a flag, who should win - the parent object or the object receiving the change?

Part of this card will be figuring out what flags need to be set and how they should be propagated.

Ideally, @markeharding wants them all to be activities with the attachments just inheriting the activities permissions, so we might want to take the opportunity to bring all our entities under the same banner. The activity has the permissions, the images, videos and blogs would just inherit their parent's permissions.

Looping in @markeharding @edgebal and @gthouret for their thoughts on how to roll this out.

Please solve the reCAPTCHA

We want to be sure it is you, please confirm you are not a robot.

Related issues
0

    • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %sprint: Jolly Jellyfish 17 minutes ago

      changed milestone to %sprint: Jolly Jellyfish

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    0 Assignees
    None
    Assign to
    None
    Epic
    None
    sprint: Jolly Jellyfish
    Milestone
    sprint: Jolly Jellyfish
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    None
    Due date
    None
    0
    Labels
    None
    Assign labels
    • View project labels
    None
    Weight
    None
    Confidentiality
    Not confidential
    Lock issue
    Unlocked
    4
    4 participants
    user avatar
    Brian Hatchet
    user avatar
    Mark Harding
    user avatar
    Emiliano Balbuena
    user avatar
    Guy Thouret
    Reference: minds/engine#616